4357
0%
main: 93%

Ran 06 Apr 2015 09:38PM UTC

Jobs 10

Files 319

Run time 38min

Badge

Embed ▾

pending completion

Build # 4357

Build Type

push

travis-ci

Committed by

baroquebobcat

Commit Message

Include classifier in JarDependency equality / hashing

https://rbcommons.com/s/twitter/r/1905 made it so that calculate_classpath included classifiers in the keys of a dict it was using, but there are a number of places where `JarDependency`s are put in sets or are compared for equality and those didn't take classifer into account. This changes JarDependency's comparison ops to use classifier. It also moves validation of artifact / classifier into the `__init__` definition so that they happen during definition rather than deep in an ivy resolve.

Changing the operators was a little tricky because there's some pants ivy code that relies on `IvyModuleRef`s duck typing as `JarDependency`s. I'm not completely sure of the effect there because it's possible that the ModuleRefs have classifiers nested in the associated artifacts. If someone else has thoughts around that I'd appreciate some suggestions.

Testing Done:
ran ci.sh locally, travis baking off of a PR

Bugs closed: 1366

Reviewed at https://rbcommons.com/s/twitter/r/2029/

Coverage Stats

12965 of 18607 relevant lines covered (69.68%)

0.7 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4357.1 (CI_FLAGS="-clpnet 'Various pants self checks'")	06 Apr 2015 09:40PM UTC		Travis Job 4357.1
2	4357.2 (CI_FLAGS="-fkmsrclpn 'Test examples and testprojects'")	06 Apr 2015 09:38PM UTC		Travis Job 4357.2
3	4357.3 (CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'")	06 Apr 2015 09:39PM UTC	69.68	Travis Job 4357.3
4	4357.4 (CI_FLAGS="-fkmsrclpet 'Python contrib tests'")	06 Apr 2015 09:39PM UTC		Travis Job 4357.4
5	4357.5 (CI_FLAGS="-fkmsrlpnet -i 6:0 'Python integration tests for pants - shard 1'")	06 Apr 2015 09:38PM UTC		Travis Job 4357.5
6	4357.6 (CI_FLAGS="-fkmsrlpnet -i 6:1 'Python integration tests for pants - shard 2'")	06 Apr 2015 09:46PM UTC		Travis Job 4357.6
7	4357.7 (CI_FLAGS="-fkmsrlpnet -i 6:2 'Python integration tests for pants - shard 3'")	06 Apr 2015 10:16PM UTC		Travis Job 4357.7
8	4357.8 (CI_FLAGS="-fkmsrlpnet -i 6:3 'Python integration tests for pants - shard 4'")	06 Apr 2015 09:46PM UTC		Travis Job 4357.8
9	4357.9 (CI_FLAGS="-fkmsrlpnet -i 6:4 'Python integration tests for pants - shard 5'")	06 Apr 2015 09:48PM UTC		Travis Job 4357.9
10	4357.10 (CI_FLAGS="-fkmsrlpnet -i 6:5 'Python integration tests for pants - shard 6'")	06 Apr 2015 09:49PM UTC		Travis Job 4357.10

Source Files on build 4357

Detailed source file information is not available for this build.

pantsbuild / pants / 4357
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4357

pantsbuild / pants / 4357 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4357

pantsbuild / pants / 4357
0%
main: 93%

README BADGES
x