3
0%
main: 93%

Ran 06 Apr 2015 09:39PM UTC

Files 319

Run time 14s

Badge

Embed ▾

Committed 06 Apr 2015 09:29PM UTC coverage: 69.678% (+0.09%) from 69.587%

Job # CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'"

Build Type

push

travis-ci

Committed by

baroquebobcat

Commit Message

Include classifier in JarDependency equality / hashing

https://rbcommons.com/s/twitter/r/1905 made it so that calculate_classpath included classifiers in the keys of a dict it was using, but there are a number of places where `JarDependency`s are put in sets or are compared for equality and those didn't take classifer into account. This changes JarDependency's comparison ops to use classifier. It also moves validation of artifact / classifier into the `__init__` definition so that they happen during definition rather than deep in an ivy resolve.

Changing the operators was a little tricky because there's some pants ivy code that relies on `IvyModuleRef`s duck typing as `JarDependency`s. I'm not completely sure of the effect there because it's possible that the ModuleRefs have classifiers nested in the associated artifacts. If someone else has thoughts around that I'd appreciate some suggestions.

Testing Done:
ran ci.sh locally, travis baking off of a PR

Bugs closed: 1366

Reviewed at https://rbcommons.com/s/twitter/r/2029/

Coverage Stats

12965 of 18607 relevant lines covered (69.68%)

0.7 hits per line

pantsbuild / pants / 4357 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4357.3 (CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'")

pantsbuild / pants / 4357 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4357.3 (CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'")

pantsbuild / pants / 4357 / 3
0%
main: 93%

README BADGES
x