4358
0%
main: 93%

Ran 06 Apr 2015 10:29PM UTC

Jobs 10

Files 319

Run time 54min

Badge

Embed ▾

pending completion

Build # 4358

Build Type

push

travis-ci

Committed by Benjy

Commit Message

Upgrade the python task tests to use TaskTestBase.

1) Upgrades the PythonTaskTest to extend TaskTestBase instead of TaskTest.
2) Make all relevant tests subclass PythonTaskTest.
3) Move a bunch of common code into that base class.

I removed some rather hacky code whose ostensible purpose was to
make the code under test use the test-invoking code's InterpreterCache.
It would have been hard to make this code work under the new scheme,
but in any case, no benchmarks I ran could detect any performance
difference before and after. Even if I kept the old code but just
commented out that hack I could see no performance difference.

Let's revisit this performance issue if it crops up, or feel free
to show me that this is necessary and I'll figure something out.

Testing Done:
CI passes: https://travis-ci.org/pantsbuild/pants/builds/57187738

Reviewed at https://rbcommons.com/s/twitter/r/2031/

Coverage Stats

12960 of 18607 relevant lines covered (69.65%)

0.7 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4358.1 (CI_FLAGS="-clpnet 'Various pants self checks'")	06 Apr 2015 10:32PM UTC		Travis Job 4358.1
2	4358.2 (CI_FLAGS="-fkmsrclpn 'Test examples and testprojects'")	06 Apr 2015 10:29PM UTC		Travis Job 4358.2
3	4358.3 (CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'")	06 Apr 2015 10:31PM UTC	69.65	Travis Job 4358.3
4	4358.4 (CI_FLAGS="-fkmsrclpet 'Python contrib tests'")	06 Apr 2015 10:31PM UTC		Travis Job 4358.4
5	4358.5 (CI_FLAGS="-fkmsrlpnet -i 6:0 'Python integration tests for pants - shard 1'")	06 Apr 2015 10:36PM UTC		Travis Job 4358.5
6	4358.6 (CI_FLAGS="-fkmsrlpnet -i 6:1 'Python integration tests for pants - shard 2'")	06 Apr 2015 10:41PM UTC		Travis Job 4358.6
7	4358.7 (CI_FLAGS="-fkmsrlpnet -i 6:2 'Python integration tests for pants - shard 3'")	06 Apr 2015 10:40PM UTC		Travis Job 4358.7
8	4358.8 (CI_FLAGS="-fkmsrlpnet -i 6:3 'Python integration tests for pants - shard 4'")	06 Apr 2015 10:40PM UTC		Travis Job 4358.8
9	4358.9 (CI_FLAGS="-fkmsrlpnet -i 6:4 'Python integration tests for pants - shard 5'")	06 Apr 2015 11:23PM UTC		Travis Job 4358.9
10	4358.10 (CI_FLAGS="-fkmsrlpnet -i 6:5 'Python integration tests for pants - shard 6'")	06 Apr 2015 10:46PM UTC		Travis Job 4358.10

Source Files on build 4358

Detailed source file information is not available for this build.

pantsbuild / pants / 4358
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4358

pantsbuild / pants / 4358 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4358

pantsbuild / pants / 4358
0%
main: 93%

README BADGES
x