|
Repo Added
|
Build
1849
Last
|
Files
129
|
Badge
README BADGES
|
push
github
fix(infra): Remove secrets from environment variables, use secret_provider architecture (#855) * fix: support both appinsights and azure secret names in metrics schema The Bicep deployment creates Key Vault secrets with these names: - appinsights-instrumentation-key - appinsights-connection-string But the schema was looking for: - azure_connection_string - azure_monitor_instrumentation_key Updated the schema to try both naming conventions for backward compatibility with local dev and Bicep deployments. * Revert "fix: support both appinsights and azure secret names in metrics schema" This reverts commit aa51f2710. * fix: align Azure Monitor secret names with schema expectations Update Bicep deployment to create Key Vault secrets with names matching the metrics adapter schema: - appinsights-instrumentation-key → azure_monitor_instrumentation_key - appinsights-connection-string → azure_connection_string These names are expected by the copilot_config secret provider adapter which reads them from Key Vault using the secret names defined in docs/schemas/configs/adapters/drivers/metrics/metrics_azure_monitor.json BREAKING: Deployments using the old secret names will need to be redeployed to use the new naming convention. * fix(infra): Remove secrets from environment variables, use secret_provider Architectural fix: Secrets should be loaded via secret_provider from Key Vault using schema secret_name field, not injected as environment variables with @Microsoft.KeyVault(...) references. Changes: - Removed APPINSIGHTS_INSTRUMENTATIONKEY and APPLICATIONINSIGHTS_CONNECTION_STRING environment variables from all 8 microservices in containerapps.bicep - These secrets are already in Key Vault (azure_monitor_instrumentation_key, azure_connection_string) and will be loaded automatically by copilot_config Phase 3 using the secret_provider with managed identity - Enhanced validate_bicep_config.py to detect architectural vi... (continued)
0 of 8 new or added lines in 1 file covered. (0.0%)
2 existing lines in 1 file now uncovered.6868 of 8362 relevant lines covered (82.13%)
0.91 hits per line
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
|---|
![]() |
Badge your Repo: CoPilot-For-ConsensusWe detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.Could not find badge in README. |
|
Embed ▾
README BADGES
|