Alan-Jowett / CoPilot-For-Consensus / 20934787988

81%

push

github

Fix: Use generic adapter discriminants (LOG_TYPE, METRICS_TYPE) instead of service-specific variants (#844)

* Fix: Use generic adapter discriminants (LOG_TYPE, METRICS_TYPE) instead of service-specific variants

Root Cause:
Services were failing at runtime because they expected generic adapter
discriminant environment variables (LOG_TYPE, METRICS_TYPE) but Bicep
was providing service-specific variants (REPORTING_LOG_TYPE, etc.).

The adapter configuration system loads adapters using generic discriminant
names defined in adapter schemas (logger.json, metrics.json), not
service-specific variants.

Changes:
1. Service Schemas: Removed duplicate log_type/metrics_type fields from
   service schemas (reporting, ingestion, parsing, orchestrator,
   summarization) as they conflicted with adapter discriminants.

2. Bicep Configuration: Fixed containerapps.bicep to use generic
   discriminant names:
   - REPORTING_LOG_TYPE -> LOG_TYPE
   - REPORTING_METRICS_TYPE -> METRICS_TYPE
   - INGESTION_METRICS_TYPE -> METRICS_TYPE
   - PARSING_LOG_TYPE -> LOG_TYPE
   - PARSING_METRICS_TYPE -> METRICS_TYPE
   - CHUNK_METRICS_TYPE -> METRICS_TYPE
   - EMBEDDING_METRICS_TYPE -> METRICS_TYPE
   - ORCHESTRATOR_LOG_TYPE -> LOG_TYPE
   - ORCHESTRATOR_METRICS_TYPE -> METRICS_TYPE
   - SUMMARIZATION_LOG_TYPE -> LOG_TYPE
   - SUMMARIZATION_METRICS_TYPE -> METRICS_TYPE

   Added missing discriminants:
   - ERROR_REPORTER_TYPE=console (all services)
   - LOG_TYPE=stdout (ingestion)
   - CONSENSUS_DETECTOR_TYPE=heuristic (orchestrator)
   - EMBEDDING_BACKEND_TYPE=ollama (orchestrator)
   - VECTOR_STORE_TYPE=qdrant (orchestrator)

3. Validation Enhancement: Updated validate_bicep_config.py to resolve
   \ pointers and validate actual adapter discriminants from
   referenced adapter schemas, not just service settings.

Testing:
All 8 microservices now pass validation:
  python scripts/validate_bicep_all_services.py infra/azure/modules/containerapps.bicep

Resolves runtime errors:
- Va... (continued)

18 of 18 new or added lines in 6 files covered. (100.0%)

6708 of 8317 relevant lines covered (80.65%)

0.9 hits per line