Alan-Jowett / CoPilot-For-Consensus / 20937037234

81%

Build Type

push

github

Committed by web-flow

Commit Message

fix: strict event validation for archive ingestion and parsing (#845)

* fix: strict event validation for archive ingestion and parsing

- startup_requeue: Add missing event envelope fields (event_id, version)
  * Generated event_id as UUID for each requeue event
  * Set version to 1.0.0 for ArchiveIngested schema compliance
  * Moved uuid import to module level per PEP 8

- parsing service: Enforce required metadata in event payload
  * Added _build_archive_ingested_event_data() validation method
  * Reject events missing source_name or source_type (required for thread correlation)
  * Validate source_type is one of valid enum: [rsync, imap, http, local]
  * Clear error messages point to ingestion service responsibility

- Result: Zero validation failures, 393/393 IETF-IPSEC archives processed successfully

* test: Update test fixtures with valid source_type enum values

- Changed test_requeue_builds_correct_event_data: source_type 'mbox' -> 'local'
- Added missing source_type field to test_requeue_handles_missing_archive_id
- Fixes compatibility with strict validation in parsing service
- All 93 parsing tests passing with 85% coverage

Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Signed-off-by: GitHub Copilot <copilot@github.com>

* Address PR #845 review comments

- Add test coverage for event_id and version fields in startup_requeue tests
  - Verify event_id is valid UUID string
  - Verify version equals '1.0.0'

- Improve _build_archive_ingested_event_data method
  - Update docstring for clarity on validation purpose
  - Extract VALID_SOURCE_TYPES as module constant
  - Remove unnecessary lambda wrapper (use method directly)

- Add comprehensive unit tests for validation logic
  - Test successful validation with all fields
  - Test ValueError when source_name missing
  - Test ValueError when source_type missing
  - Test ValueError when source_type invalid
  - Test all valid enum values accepted

- Fix ingestion service
  - Simplify cache ref... (continued)

Run Details

13 of 18 new or added lines in 2 files covered. (72.22%)

1 existing line in 1 file now uncovered.

6721 of 8333 relevant lines covered (80.66%)

0.9 hits per line