You are now the owner of this repo.

decentraland / social-service-ea
90%

DEFAULT BRANCH: main
Repo Added
Token yVQPxl84f3ylLrh667GFCB6oecdrhNj1d regen
Build 1212 Last
Files 192
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 89.588% (-0.6%) from 90.219%
24508747248

push

github

web-flow 
fix: prevent OOM crashes from subscriber leak and duplicate subscriptions (#407)

* fix: prevent OOM crashes from subscriber leak and duplicate subscriptions

Three critical fixes for the heap exhaustion crash (510 MB after ~62h):

1. Fix cleanup bug in ws-handler: the three cleanup steps (transport.close,
   detachUser, emitter.clear) were in a single try/catch. If transport.close()
   threw (uWS throws on closed sockets), detachUser and emitter.clear were
   skipped, permanently leaking the subscriber's emitter and generators.
   Each step is now an independent function with its own error handling.

2. Guard against duplicate subscriptions: clients can call the same stream
   RPC multiple times on one connection. Each call created another async
   generator with a 1000-item value queue, doubling memory per connection.
   Crash logs confirmed this for communityMemberConnectivityUpdate.
   Added per-(address, event) deduplication in handleSubscriptionUpdates.

3. Set explicit V8 heap limit (768 MB for 1024 MB prod containers) via
   NODE_OPTIONS env var in Dockerfile, overridable at deploy time.

* fix: add cork wrapping, subscriber metrics, reconciliation, and sScan

Hardening changes to complement the critical OOM fixes:

1. Wrap all HTTP responses in res.cork() to prevent uWS warnings about
   writes outside corked callbacks. Under GC pressure these interleaved
   writes can hold object references longer than necessary.

2. Add subscriber monitoring metrics (gauges): subscribers_local_count,
   subscribers_generators_count, subscribers_redis_set_size, and a
   subscribers_stale_cleaned counter. Reported every 30s via setInterval.

3. Add periodic stale subscriber reconciliation (every 5 min, configurable
   via SUBSCRIBER_RECONCILIATION_INTERVAL_MS). Cross-references local
   subscribers against active WS connections from wsPool and removes any
   orphaned subscribers that the cleanup path missed.

4. Replace redis.sMembers() with redis.client.sSca... (continued)

2220 of 2615 branches covered (84.89%)

Branch coverage included in aggregate %.

70 of 122 new or added lines in 7 files covered. (57.38%)

2 existing lines in 1 file now uncovered.

5472 of 5971 relevant lines covered (91.64%)

71.43 hits per line

Relevant lines Covered
5971 RELEVANT LINES 5472 COVERED LINES
71.43 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
24508747248 main fix: prevent OOM crashes from subscriber leak and duplicate subscriptions (#407) * fix: prevent OOM crashes from subscriber leak and duplicate subscriptions Three critical fixes for the heap exhaustion crash (510 MB after ~62h): 1. Fix cleanup ... push web-flow github
89.59
24456811103 fix/oom-subscriber-leak-and-heap-limit fix: move heap limit from NODE_OPTIONS to CMD args Move --max-old-space-size=768 into the CMD line alongside the other Node.js flags, matching the existing project convention. Removes the NODE_OPTIONS env var which could interact unexpectedly wit... Pull #407 kevinszuchet github
89.59
24455772176 fix/oom-subscriber-leak-and-heap-limit fix: add cork wrapping, subscriber metrics, reconciliation, and sScan Hardening changes to complement the critical OOM fixes: 1. Wrap all HTTP responses in res.cork() to prevent uWS warnings about writes outside corked callbacks. Under GC pre... Pull #407 kevinszuchet github
89.59
24449911581 fix/oom-subscriber-leak-and-heap-limit fix: prevent OOM crashes from subscriber leak and duplicate subscriptions Three critical fixes for the heap exhaustion crash (510 MB after ~62h): 1. Fix cleanup bug in ws-handler: the three cleanup steps (transport.close, detachUser, emitter.... Pull #407 kevinszuchet github
90.18
23739845667 1.11.0 fix: resolve OOM crashes with heap limit, TTL-based subscribers, and SCAN (#406) * fix: resolve OOM crashes with heap limit, TTL-based subscribers, and SCAN * fix: prettier formatting in subscribers-context * revert: remove TTL-based subscriber... push web-flow github
90.22
23593170934 main fix: resolve OOM crashes with heap limit, TTL-based subscribers, and SCAN (#406) * fix: resolve OOM crashes with heap limit, TTL-based subscribers, and SCAN * fix: prettier formatting in subscribers-context * revert: remove TTL-based subscriber... push web-flow github
90.22
23543551575 fix/memory-leak-heap-limit-and-stale-subscribers perf: use mGet instead of individual get calls in community voice cache Replace Promise.all of N individual redis.get() calls with a single redis.mGet() call in getActiveCommunityVoiceChats, reducing N Redis round-trips to 1. Pull #406 kevinszuchet github
90.22
23539722249 fix/memory-leak-heap-limit-and-stale-subscribers fix: revert subscriber tests to match SET-based source code The TTL-based subscriber changes were reverted in the source but the tests were updated to expect TTL-based behavior, causing TS compilation errors (config not in Pick<BaseComponents, 'r... Pull #406 kevinszuchet github
90.18
23499911921 fix/memory-leak-heap-limit-and-stale-subscribers fix: pin localstack to 4.12.0 to fix CI localstack/localstack:latest broke with the 2026.03.0 release (exit code 55). Pin to 4.12.0 which was the last working version. Pull #406 kevinszuchet github
90.18
23319900821 fix/401-ban-chain-bypass-missing-intermediate fix: walk full referral chain to detect banned ancestors The previous ban chain detection only checked 1 level up (the immediate parent referrer). If an intermediate referrer was not in the DB, or the banned wallet was 2+ hops away, the check wou... Pull #405 root github
90.19
See All Builds (1187)