decentraland / social-service-ea / 29494920620

90%

main: 90%

Build Type

Pull #434

github

Committed by decentraland-bot

Commit Message

fix: add missing .catch() handlers to prevent unhandled promise rejection crashes

Under Node 24's --unhandled-rejections=strict (the service's start script),
any fire-and-forget async call without a .catch() handler will abort the
process (SIGABRT, exit 134) if the promise rejects.

This commit adds .catch() rejection handlers to three void-called async
functions that were missing them:

1. broadcastCommunityRenamed (communities.ts:678) — HIGH risk: calls
   communityThumbnail.getThumbnail() which can throw on S3/storage failure
2. notifyAboutNewRequest (requests.ts:187) — defensive hardening
3. notifyStakeholdersAboutRequest (requests.ts:310) — defensive hardening

These follow the same pattern already established by broadcastCommunityDeleted
(communities.ts:570) and broadcastOwnershipTransferred (communities.ts:141).

Closes #433

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Pull Request Pull Request #434: fix: add missing .catch() handlers to prevent unhandled promise rejection crashes

Coverage Stats

2354 of 2761 branches covered (85.26%)

Branch coverage included in aggregate %.

2 of 5 new or added lines in 2 files covered. (40.0%)

10 existing lines in 2 files now uncovered.

5881 of 6359 relevant lines covered (92.48%)

80.41 hits per line