decentraland / social-service-ea
90%

DEFAULT BRANCH: main
Repo Added
Token yVQPxl84f3ylLrh667GFCB6oecdrhNj1d regen
Build 1286 Last
Files 202
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 90.326% (+0.02%) from 90.311%
29113386552

push

github

web-flow 
feat: inform clients why a subscription stream is closed (#432)

* feat: inform clients why a subscription stream is closed

Uses the new SubscriptionStreamClosed message from @dcl/protocol: before a
server-initiated close, the stream now yields a final message carrying a
close reason (and optional detail) instead of ending silently.

- emitterToGenerator: destroy() accepts an optional close reason, exposed
  via getCloseReason() so the consumer loop can act on it after draining.
- subscribers-context: teardown paths tag their reason — SERVER_SHUTTING_DOWN
  on stop, STALE_SUBSCRIPTION on both reconciliation sweeps — and
  removeConnection() forwards an optional caller-provided reason.
- handleSubscriptionUpdates: rejected duplicate subscriptions now tell the
  client why (DUPLICATE_SUBSCRIPTION) before closing, and destroys with a
  reason yield a final stream-closed message when the service provides a
  builder for it.
- All six subscribe services build the final message with fromPartial so it
  is protobuf-complete (zero-value defaults plus the notice).

Delivery is best-effort by nature: the final message only reaches clients
whose connection is still alive (duplicate rejection, shutdown drain);
teardowns triggered by an already-dead socket have no one to inform.

* refactor: drop undeliverable subscription stream close reasons

Only the duplicate-subscription rejection can actually deliver a close notice —
the connection is still alive there. Shutdown and stale-cleanup closes run after
the socket is gone, so their reasons never reached the client. Remove that dead
plumbing: the close-reason parameter on emitterToGenerator's destroy() (and its
getCloseReason accessor), the reason threading through subscribers-context
teardown paths, and the post-loop reason forwarding in handleSubscriptionUpdates.

The duplicate-subscription path (the one that works) is unchanged.

* chore: bump @dcl/protocol to the trimmed stream-close-reason build

Repoints to t... (continued)

2354 of 2761 branches covered (85.26%)

Branch coverage included in aggregate %.

12 of 13 new or added lines in 7 files covered. (92.31%)

5881 of 6356 relevant lines covered (92.53%)

80.45 hits per line

Relevant lines Covered
6356 RELEVANT LINES 5881 COVERED LINES
80.45 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
29113386552 main feat: inform clients why a subscription stream is closed (#432) * feat: inform clients why a subscription stream is closed Uses the new SubscriptionStreamClosed message from @dcl/protocol: before a server-initiated close, the stream now yields a... push web-flow github
90.33
29111602752 feat/subscription-stream-close-reason chore: bump @dcl/protocol to the trimmed stream-close-reason build Repoints to the build of protocol #439's final commit, where the enum is STREAM_CLOSED_DUPLICATE_SUBSCRIPTION = 1 (the previous pin predated the trim and still had it at 2). Align... Pull #432 LautaroPetaccio github
90.33
29103608044 feat/subscription-stream-close-reason refactor: drop undeliverable subscription stream close reasons Only the duplicate-subscription rejection can actually deliver a close notice — the connection is still alive there. Shutdown and stale-cleanup closes run after the socket is gone, so... Pull #432 LautaroPetaccio github
90.33
29098302998 feat/subscription-stream-close-reason feat: inform clients why a subscription stream is closed Uses the new SubscriptionStreamClosed message from @dcl/protocol: before a server-initiated close, the stream now yields a final message carrying a close reason (and optional detail) instea... Pull #432 LautaroPetaccio github
90.34
29035927692 chore/typescript-7-native-build chore: build and type-check with the native TypeScript 7 compiler Clean builds drop from ~3.7s to ~0.7s (~5x) with byte-identical emitted JavaScript. TypeScript 7 ships only the native binary, without the JS compiler API that ts-jest, ts-node an... Pull #431 LautaroPetaccio github
90.31
29033915825 1.13.2 feat: add RPC_TRACING_ENABLED flag to toggle Sentry RPC tracing (#430) * feat: add RPC_TRACING_ENABLED flag to toggle Sentry RPC tracing Wrap the per-call/stream RPC Sentry spans behind a new RPC_TRACING_ENABLED env flag (default enabled, preser... push web-flow github
90.31
29029690638 main feat: add RPC_TRACING_ENABLED flag to toggle Sentry RPC tracing (#430) * feat: add RPC_TRACING_ENABLED flag to toggle Sentry RPC tracing Wrap the per-call/stream RPC Sentry spans behind a new RPC_TRACING_ENABLED env flag (default enabled, preser... push web-flow github
90.31
29028770370 feat/rpc-tracing-toggle test: address RPC tracing flag review comments - Compare RPC_TRACING_ENABLED case-insensitively so FALSE/False also disable it - Add test locking in the default-enabled contract when the var is unset - Add error-path tests (call + stream) with tr... Pull #430 LautaroPetaccio github
90.31
29028080454 feat/rpc-tracing-toggle feat: add RPC_TRACING_ENABLED flag to toggle Sentry RPC tracing Wrap the per-call/stream RPC Sentry spans behind a new RPC_TRACING_ENABLED env flag (default enabled, preserving current behavior). When set to 'false', the handler runs inside suppr... Pull #430 LautaroPetaccio github
90.31
28624024661 main fix: harden WS transport, subscriptions, RPC startup and backpressure (#429) * fix: harden WS transport, subscriptions, RPC startup and backpressure Transport (UWebSocketTransport): - Attach a no-op catch to each message future so fire-and-forge... push web-flow github
90.3
See All Builds (1261)