decentraland / social-service-ea / 29753732793

90%

main: 90%

Build Type

push

github

Committed by web-flow

Commit Message

fix: prevent websocket cleanup unhandled rejection (#436)

* fix: prevent websocket cleanup unhandled rejection

* fix: harden remaining WS fire-and-forget paths against unhandled rejections

Follow-up to the websocket cleanup crash fix: sweep the rest of the WS code
for the same class of defect (a promise that can reject with no handler, or a
throw escaping into a fire-and-forget call) and close the remaining gaps.

- transport: route every fire-and-forget processQueue() call through a guarded
  runQueueProcessing() helper. processQueue emits 'error' synchronously, which
  tears the transport down across modules; a throw in that chain would reject
  the floating promise as an unhandled rejection.
- ws-handler: the transport 'close' listener now detaches via safeDetachUser,
  matching the cleanupConnection path, so a detach failure can't escape into
  the transport's queue processing.
- ws-handler: guard both ws.send() calls, consistent with every ws.end() site
  (ws.send throws on an already-closed socket).
- ws-pool: guard each connection teardown in stop() so one already-closing
  socket can't abort the graceful shutdown of the rest.

Each change ships with a regression test verified to fail without the fix.

---------

Co-authored-by: LautaroPetaccio <lausuper@gmail.com>

Coverage Stats

2357 of 2766 branches covered (85.21%)

Branch coverage included in aggregate %.

17 of 19 new or added lines in 3 files covered. (89.47%)

18 existing lines in 3 files now uncovered.

5890 of 6367 relevant lines covered (92.51%)

80.48 hits per line