No new info detected.

ovn-kubernetes / libovsdb
50%
main: 48%

LAST BUILD BRANCH: conmgr
DEFAULT BRANCH: main
Repo Added
Token FBHmVryAtOC95uh0zdETtZHdbzPZ1o7QC regen
Build 962 Last
Files 75
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH conmgr
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 49.512% (+1.4%) from 48.092%
25911161236

Pull #472

github

dave-tucker 
client: fix lifecycle event drops and remove grace-timer reconnect suppression

Two correctness issues identified in code review:

1. EventDisconnected/Reconnected/SchemaData competed with EventInboundRPC on
   a single 64-slot non-blocking channel. Under an inbound-update burst,
   lifecycle events could be silently dropped, leaving the client with stale
   state and unrepaired monitors.

   Fix: introduce a dedicated lifecycleCh (cap 8, blocking send) for lifecycle
   events. EventInboundRPC stays on eventCh (cap 64, non-blocking) where
   occasional drops under load are acceptable. runEventLoop uses a priority
   double-select that drains lifecycleCh before blocking on eventCh.

2. After Connect(), setReconnectTime() armed a 3-second suppression window.
   When the OVS container restarted within that window, withinReconnectGrace()
   swallowed the disconnect signal from rpc2, leaving the client in Connected
   state with a dead TCP socket. TestWithReconnect was permanently skipped
   because of this.

   Fix: use rpcClient.DisconnectNotify() directly as the disconnect signal in
   the run-loop select. rpc2 closes this channel when that specific client
   closes; each new connection produces a new channel, so signals from a
   previous connection are naturally abandoned — no grace timer needed.
   Remove setReconnectTime/withinReconnectGrace/startDisconnectWatcher and the
   drain-sleep-drain loops in doCmdConnect and runReconnectLoop.

Unskip TestWithReconnect now that the underlying bug is fixed.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Pull Request #472: client: introduce ConnectionManager to fix reconnect/disconnect panics

807 of 967 new or added lines in 5 files covered. (83.45%)

16 existing lines in 1 file now uncovered.

6547 of 13223 relevant lines covered (49.51%)

134.12 hits per line

Relevant lines Covered
13223 RELEVANT LINES 6547 COVERED LINES
134.12 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
25911161236 conmgr client: fix lifecycle event drops and remove grace-timer reconnect suppression Two correctness issues identified in code review: 1. EventDisconnected/Reconnected/SchemaData competed with EventInboundRPC on a single 64-slot non-blocking channe... Pull #472 dave-tucker github
49.51
25870806382 conmgr client: introduce ConnectionManager to fix reconnect/disconnect races Add a ConnectionManager (CM) — a finite-state machine goroutine that owns all OVSDB connection lifecycle and proxies RPC calls, eliminating the data races and panics that occur... Pull #472 dave-tucker github
49.38
25869641553 conmgr test: fix TestMultipleOpsSameRow timeout and model reuse on OVS 3.3.0 The 2-second Eventually timeout was too tight for OVS 3.3.0 given the two-transact setup (create + 5-op modify on the same row). Increase to 5 seconds to match other tests in t... Pull #472 dave-tucker github
49.37
25868380124 conmgr test: fix TestMultipleOpsTransactIntegration map merge bug model.CloneInto uses json.Unmarshal which merges into existing maps rather than replacing them. If the Eventually loop runs once before the update3 modify notification is processed, br.Ex... Pull #472 dave-tucker github
49.26
25801728188 main Merge pull request #477 from dave-tucker/fix-ovs-workflows-permission ci: add workflows permission to check-ovs-versions push web-flow github
48.09
25799064960 main Merge pull request #474 from ovn-kubernetes/contributing docs: add CONTRIBUTING.md, retire HACKING.md push web-flow github
48.15
22687191162 fix-trafficseen-close-race client: fix SetOption() to check connected flag instead of rpcClient TestOpsWaitForReconnect was failing because after Disconnect() is called, the connected flag is set to false immediately, but rpcClient is only set to nil later by handleDisconn... Pull #459 booxter github
48.22
22687128641 fix-trafficseen-close-race client: fix SetOption() to check connected flag instead of rpcClient TestOpsWaitForReconnect was failing because after Disconnect() is called, the connected flag is set to false immediately, but rpcClient is only set to nil later by handleDisconn... Pull #459 booxter github
48.16
22585466877 main Merge pull request #457 from booxter/fix-rpc-shutdown-race push web-flow github
48.15
22584268592 main Merge pull request #453 from ovn-kubernetes/dependabot/go_modules/golang.org/x/crypto-0.45.0 build(deps): bump golang.org/x/crypto from 0.38.0 to 0.45.0 push web-flow github
48.13
See All Builds (962)

Badge your Repo: libovsdb

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh