ovn-kubernetes / libovsdb

76%

main: 50%

LAST BUILD ON BRANCH named-uuid-cleanup

branch: named-uuid-cleanup

CHANGE BRANCH

x

Reset

Sync Branches

• named-uuid-cleanup
• allow_prom_ns_definition
• any
• api-fix
• applymod-set
• auto-reconnect
• avoid-multi-level-map-access
• base-type
• bench
• benchmark-apicreate
• bug/433
• bugfix/connect-with-timeout
• cache
• cache-clone-not-lookup-twice
• cache-debuglogging
• cache-exit-run
• cache-indexes
• check-sid
• cleanup
• cli-options
• client
• client-iface
• client-validate
• close-without-serve
• codeql
• cond_mon
• condition
• create_multiple
• cutdown_reconnect_logging
• deepcopy
• dep_bot_merge
• dependabot
• dependabot/github_actions/github-actions-970b8d0e10
• dependabot/github_actions/github-actions-a331d3ec2d
• dependabot/github_actions/github-actions-c836e40089
• dependabot/go_modules/github.com/docker/docker-20.10.24incompatible
• dependabot/go_modules/github.com/docker/docker-24.0.7incompatible
• dependabot/go_modules/github.com/docker/docker-24.0.9incompatible
• dependabot/go_modules/github.com/docker/docker-28.0.0incompatible
• dependabot/go_modules/github.com/go-viper/mapstructure/v2-2.3.0
• dependabot/go_modules/github.com/go-viper/mapstructure/v2-2.4.0
• dependabot/go_modules/github.com/opencontainers/runc-1.1.12
• dependabot/go_modules/github.com/opencontainers/runc-1.1.14
• dependabot/go_modules/github.com/opencontainers/runc-1.1.5
• dependabot/go_modules/go-dependencies-0f877749ad
• dependabot/go_modules/go-dependencies-2410d55ef4
• dependabot/go_modules/go-dependencies-52cc044f02
• dependabot/go_modules/go-dependencies-e457808fc3
• dependabot/go_modules/go-dependencies-fddcb94d8d
• dependabot/go_modules/golang.org/x/crypto-0.35.0
• dependabot/go_modules/golang.org/x/net-0.17.0
• dependabot/go_modules/golang.org/x/net-0.23.0
• dependabot/go_modules/golang.org/x/net-0.7.0
• dependabot/go_modules/golang.org/x/text-0.3.8
• dependabot/go_modules/google.golang.org/protobuf-1.33.0
• doc
• dynamic-ep
• empty_list
• encodingCleanup
• enforce_index_checking
• enum
• enum-num
• errors
• events-list
• events-pointer
• expand-named-uuids-rows
• export-ovsdbclient
• faster-mutliarch
• feat/modelgen-enum
• feat/refact-new-gen
• feature/cluster-support
• feature/logger-metrics
• fix-201
• fix-212
• fix-216
• fix-arg
• fix-caps
• fix-comment-op
• fix-deadlock
• fix-delete
• fix-digest
• fix-indexes
• fix-make-local
• fix-modelgen-path
• fix-monitor-fallback
• fix-overflow
• fix-play-with-ovs
• fix-pointer-issue
• fix-readme
• fix-reconnect
• fix-row
• fix-server
• fix-server-again
• fix-set-size-1
• fix-types-api
• fix/203
• fix/add-print-schema-test
• fix/print-schema-without-reftype
• fix_cache_errors
• fix_conn_leak_at_monitor_failure
• fix_handling_cache
• fix_import
• fix_mod_missing_column
• fix_monitors_deadlock
• fix_nil_column_keys
• fix_null_ptr_metric
• fix_ovs_set
• fix_ptr_indirect
• fix_rebase
• fix_reg_once
• fix_server_close
• fix_server_err
• fix_wait_timeout
• gen_refactor
• getExternalIDs
• getbyindex
• go-up
• golangci-fix
• implement_wait_method
• inactivity-check
• index-deferred
• insert-not-present
• issue/319
• issue232
• issue303_monitorFields
• issue303_monitorFields.try2
• it
• json-adapter
• libovsdb-txn-log
• log-more
• macos-integration
• main
• makefile.merge
• mapper-field-by-column-error
• me-maintainer
• moar-fixes
• moar-linting
• moar-panics
• moar_fixes
• modelgen
• modelgen-const
• modelgen-order
• modelgen-schema
• modelgen-table-name
• modelgen_fix
• monitor
• monitor-cond-since
• monitor-cond-since-simple
• monitor-select
• monitor_condition_v1
• move_api
• multi-arch-ovs
• multi_column_cache
• mv-cache
• no-clone-where
• no-index
• noptr
• old
• optional
• optional_blocking_with_reconnect
• optional_nil_update
• orm
• orm-crud
• otel
• ovn-kubernetes
• ovs-perms
• ovs-test-up
• ovs-up
• ovs-update
• ovsdb-server
• ovsdb-tag
• patch-1
• perf/list-mem
• perf/wherecache
• pointer-column
• protect_cache_read
• ptr
• ptrs
• rando_fixes2
• readme-fix
• reconnect
• reconnect-to-something-else
• reduce-name-stutter
• refactor
• references
• reg_metrics_once
• release
• remove-clone
• revert-412-dependabot/go_modules/go-dependencies-e457808fc3
• rlock-row-by-model
• rowcache-deadlock
• rowupdate-easyjson
• runc-upgrade
• schema
• select
• select-columns
• select-new
• select-refact
• send-echo-async-for-inactivity-check
• send-echo-async-v2
• separate_timeout
• server
• server-error-handling
• server-map-mutate
• server-panic
• server-txn
• sets-as-slice
• show_me_your_uuids
• stress
• test
• test-focus
• test-images-wf
• test_integration_multiple_ops
• testgen
• tidy
• timeout
• tmp-fix
• transact-fix
• transact-no-log
• translog
• tweak-loglevel
• uint64
• update
• update-channels
• update-perf
• update-refactor
• update_go118
• us_fixes
• use-contexts
• uuid_map
• variadic
• verify-indexes
• wait-check-now
• wait_api
• wait_api_integration_test
• wait_fixes
• where
• where-many
• wherecachetyped

Build # 5416881819

Build Type

Pull #359

github

Committed by dcbw

Commit Message

ovsdb: partial revert of "mapper: Add _uuid when calling NewRow"

This is a partial revert of commit bbcbf5a93

The reverted commit prevents marshalling named UUIDs into a Row's _uuid
field. But that's kind of silly because the _uuid field shouldn't ever be
filled in for requests from client -> server, whether named or real.

There are only two operations that use Rows: Insert and Update. On Insert
ovsdb-server overwrites the given Row's _uuid with either the UUID given
in the Operation, or a generated one. On Update it throws an error since
_uuid is immutable. So there's zero point to letting _uuid through.

But it may be useful internally when dealing with Rows to allow both
regular and named UUIDs in the _uuid field, whether for testcases or
constructing strings of Operations before sending to the server.

Thus, do the same thing in Insert that Update already does: specifically
remove _uuid from the row as late as possible, right before sending the
Operation to the server via RPC.

Signed-off-by: Dan Williams <dcbw@redhat.com>

Pull Request Pull Request #359: Named UUID cleanup and enhancements

Run Details

154 of 154 new or added lines in 5 files covered. (100.0%)

5211 of 6874 relevant lines covered (75.81%)

121.37 hits per line