ovn-kubernetes / libovsdb

48%

main: 48%

LAST BUILD ON BRANCH fix-trafficseen-close-race

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• allow_prom_ns_definition
• any
• api-fix
• applymod-set
• auto-reconnect
• avoid-multi-level-map-access
• base-type
• bench
• benchmark-apicreate
• bug/433
• bugfix/connect-with-timeout
• cache
• cache-clone-not-lookup-twice
• cache-debuglogging
• cache-exit-run
• cache-indexes
• check-sid
• cleanup
• cli-options
• client
• client-iface
• client-validate
• close-without-serve
• codeql
• cond_mon
• condition
• create_multiple
• cutdown_reconnect_logging
• db_change_aware
• deepcopy
• dep_bot_merge
• dependabot
• dependabot/github_actions/github-actions-970b8d0e10
• dependabot/github_actions/github-actions-a331d3ec2d
• dependabot/github_actions/github-actions-c836e40089
• dependabot/go_modules/github.com/docker/docker-20.10.24incompatible
• dependabot/go_modules/github.com/docker/docker-24.0.7incompatible
• dependabot/go_modules/github.com/docker/docker-24.0.9incompatible
• dependabot/go_modules/github.com/docker/docker-28.0.0incompatible
• dependabot/go_modules/github.com/go-viper/mapstructure/v2-2.3.0
• dependabot/go_modules/github.com/go-viper/mapstructure/v2-2.4.0
• dependabot/go_modules/github.com/opencontainers/runc-1.1.12
• dependabot/go_modules/github.com/opencontainers/runc-1.1.14
• dependabot/go_modules/github.com/opencontainers/runc-1.1.5
• dependabot/go_modules/github.com/opencontainers/runc-1.2.8
• dependabot/go_modules/go-dependencies-0f877749ad
• dependabot/go_modules/go-dependencies-2410d55ef4
• dependabot/go_modules/go-dependencies-52cc044f02
• dependabot/go_modules/go-dependencies-e457808fc3
• dependabot/go_modules/go-dependencies-fddcb94d8d
• dependabot/go_modules/golang.org/x/crypto-0.35.0
• dependabot/go_modules/golang.org/x/net-0.17.0
• dependabot/go_modules/golang.org/x/net-0.23.0
• dependabot/go_modules/golang.org/x/net-0.7.0
• dependabot/go_modules/golang.org/x/text-0.3.8
• dependabot/go_modules/google.golang.org/protobuf-1.33.0
• doc
• dynamic-ep
• empty_list
• encodingCleanup
• enforce_index_checking
• enum
• enum-num
• errors
• events-list
• events-pointer
• expand-named-uuids-rows
• export-ovsdbclient
• faster-mutliarch
• feat/modelgen-enum
• feat/refact-new-gen
• feature/cluster-support
• feature/logger-metrics
• fix-201
• fix-212
• fix-216
• fix-arg
• fix-caps
• fix-comment-op
• fix-deadlock
• fix-delete
• fix-digest
• fix-indexes
• fix-make-lint-path
• fix-make-local
• fix-modelgen-path
• fix-monitor-fallback
• fix-overflow
• fix-play-with-ovs
• fix-pointer-issue
• fix-readme
• fix-reconnect
• fix-row
• fix-rpc-shutdown-race
• fix-server
• fix-server-again
• fix-set-size-1
• fix-trafficSeen-race
• fix-trafficseen-close-race
• fix-types-api
• fix/203
• fix/add-print-schema-test
• fix/print-schema-without-reftype
• fix_cache_errors
• fix_conn_leak_at_monitor_failure
• fix_handling_cache
• fix_import
• fix_mod_missing_column
• fix_monitors_deadlock
• fix_nil_column_keys
• fix_null_ptr_metric
• fix_ovs_set
• fix_ptr_indirect
• fix_rebase
• fix_reg_once
• fix_server_close
• fix_server_err
• fix_wait_timeout
• gen_refactor
• getExternalIDs
• getbyindex
• go-up
• golangci-fix
• implement_wait_method
• inactivity-check
• index-deferred
• insert-not-present
• issue/319
• issue232
• issue303_monitorFields
• issue303_monitorFields.try2
• it
• json-adapter
• libovsdb-txn-log
• log-more
• macos-integration
• main
• makefile.merge
• mapper-field-by-column-error
• me-maintainer
• moar-fixes
• moar-linting
• moar-panics
• moar_fixes
• modelgen
• modelgen-const
• modelgen-diff-not-detected-in-ci
• modelgen-order
• modelgen-schema
• modelgen-table-name
• modelgen_fix
• monitor
• monitor-cond-since
• monitor-cond-since-simple
• monitor-select
• monitor_condition_v1
• move_api
• multi-arch-ovs
• multi_column_cache
• mv-cache
• named-uuid-cleanup
• no-clone-where
• no-index
• noptr
• old
• optional
• optional_blocking_with_reconnect
• optional_nil_update
• orm
• orm-crud
• otel
• ovn-kubernetes
• ovs-perms
• ovs-test-up
• ovs-up
• ovs-update
• ovsdb-server
• ovsdb-tag
• patch-1
• perf/list-mem
• perf/wherecache
• pointer-column
• protect_cache_read
• ptr
• ptrs
• rando_fixes2
• readme-fix
• reconnect
• reconnect-to-something-else
• reduce-name-stutter
• refactor
• references
• reg_metrics_once
• release
• remove-clone
• revert-412-dependabot/go_modules/go-dependencies-e457808fc3
• rlock-row-by-model
• rowcache-deadlock
• rowupdate-easyjson
• runc-upgrade
• schema
• select
• select-columns
• select-new
• select-refact
• send-echo-async-for-inactivity-check
• send-echo-async-v2
• separate_timeout
• server
• server-error-handling
• server-map-mutate
• server-panic
• server-txn
• sets-as-slice
• show_me_your_uuids
• stress
• test
• test-focus
• test-images-wf
• test_integration_multiple_ops
• testgen
• tidy
• timeout
• tmp-fix
• transact-fix
• transact-no-log
• translog
• tweak-loglevel
• uint64
• update
• update-channels
• update-perf
• update-refactor
• update_go118
• us_fixes
• use-contexts
• uuid_map
• variadic
• verify-indexes
• wait-check-now
• wait_api
• wait_api_integration_test
• wait_fixes
• where
• where-many
• wherecachetyped

Build # 22687191162

Build Type

Pull #459

github

Committed by booxter

Commit Message

client: fix SetOption() to check connected flag instead of rpcClient

TestOpsWaitForReconnect was failing because after Disconnect() is called,
the connected flag is set to false immediately, but rpcClient is only set
to nil later by handleDisconnectNotification(). This creates a window where
SetOption() would check rpcClient != nil and fail even though the client
is disconnected.

Fix by checking the connected flag instead of rpcClient in SetOption().
This is the correct check since connected accurately reflects the client
state from the caller's perspective.

Fixes TestOpsWaitForReconnect integration test.

Signed-off-by: Ihar Hrachyshka <ihrachyshka@nvidia.com>
Assisted-by: opus (claude-opus-4-5-20251101)

Pull Request Pull Request #459: client: fix send on closed channel panic during disconnect

Run Details

21 of 21 new or added lines in 1 file covered. (100.0%)

4 existing lines in 1 file now uncovered.

6173 of 12803 relevant lines covered (48.22%)

171.71 hits per line