Warning: This build has drifted.
The coverage report for this pull request build may be inaccurate because its base commit is no longer the HEAD of its target branch.
This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

    • Learn more: For more information on this, see Tracking coverage changes for pull request builds.
    • Fix now: For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
    • Prevent going forward: To avoid this issue with future PRs, see these Recommended CI Configurations.

client: fix lifecycle event drops and remove grace-timer reconnect suppression

Two correctness issues identified in code review:

1. EventDisconnected/Reconnected/SchemaData competed with EventInboundRPC on
   a single 64-slot non-blocking channel. Under an inbound-update burst,
   lifecycle events could be silently dropped, leaving the client with stale
   state and unrepaired monitors.

   Fix: introduce a dedicated lifecycleCh (cap 8, blocking send) for lifecycle
   events. EventInboundRPC stays on eventCh (cap 64, non-blocking) where
   occasional drops under load are acceptable. runEventLoop uses a priority
   double-select that drains lifecycleCh before blocking on eventCh.

2. After Connect(), setReconnectTime() armed a 3-second suppression window.
   When the OVS container restarted within that window, withinReconnectGrace()
   swallowed the disconnect signal from rpc2, leaving the client in Connected
   state with a dead TCP socket. TestWithReconnect was permanently skipped
   because of this.

   Fix: use rpcClient.DisconnectNotify() directly as the disconnect signal in
   the run-loop select. rpc2 closes this channel when that specific client
   closes; each new connection produces a new channel, so signals from a
   previous connection are naturally abandoned — no grace timer needed.
   Remove setReconnectTime/withinReconnectGrace/startDisconnectWatcher and the
   drain-sleep-drain loops in doCmdConnect and runReconnectLoop.

Unskip TestWithReconnect now that the underlying bug is fixed.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>