pantsbuild / pants
93%

DEFAULT BRANCH: main
Repo Added
Files 1754
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 92.791% (+0.004%) from 92.787%
26431083026

push

github

web-flow 
fix(js): include workspace member node_modules in install sandbox (#23342)

# Problem

In a nodejs workspace, each project of the workspace can have its own
`node_modules` directory that is populated during installation.
Previously, pants was capturing the project's workspace and the
top-level workspace but not sibling or descendent projects. This caused
certain operations to fail, such as `tsc --build` on a pnpm workspace
project since a pnpm project doesn't hoist member deps to the root by
default. Outside of pnpm, there are reports of this causing problems
with yarn/npm projects where a version conflict prevents hoisting.

# Solution

In `node_modules_directories`, the install sandbox now captures every
workspace member's `node_modules/`, not just the build target's.

Note: the new behavior only impacts the install path ( when
`self.package` is set). Lockfile generation's codepath
(via`NodeJsProjectEnvironment.from_root()`) doesn't set `self.package`
and keeps the "root only" behavior. Dropping the `if self.package` check
would align with the approach from #23264, but I left out that change to
minimize the scope. I added a test to demonstrate this behavior.

# AI Disclosure

Claude Code was used to diagnose the problem, write the fix with my
input, and write the regression tests

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

63 of 63 new or added lines in 3 files covered. (100.0%)

93062 of 100292 relevant lines covered (92.79%)

4.02 hits per line

Relevant lines Covered
100292 RELEVANT LINES 93062 COVERED LINES
4.02 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
26431083026 main fix(js): include workspace member node_modules in install sandbox (#23342) # Problem In a nodejs workspace, each project of the workspace can have its own `node_modules` directory that is populated during installation. Previously, pants was capt... push web-flow github
92.79
26402722782 fix/terminal-width-fallback Merge 1cbe48321 into 58bd69c82 Pull #23364 web-flow github
92.78
26380816428 cherry-pick-23363-to-2.32.x Merge 7410b48e1 into 7b1060c81 Pull #23368 web-flow github
52.31
26377393536 main Prepare 2.33.0.dev2 (#23367) push web-flow github
92.79
26372809345 automation/release/2.33.0.dev2 Merge c1e333b4a into b2edb6073 Pull #23367 web-flow github
92.79
26342152999 main Run Linux ARM CI on Depot runners (#23363) RunsOn is deprecating their v2 stack, and rather than migrate to v3 we should use the resources kindly donated by Depot. GitHub also now has Linux ARM runners, should we need them. push web-flow github
91.16
26338762827 main Fix NG subsystem mypy plugin (#23334) The previous implementation failed if the subsystem extended an intermediate SubsystemNg subclass instead of SubsystemNg directly. This change switches to get_base_class_hook, so that setting abstract_stat... push web-flow github
92.79
26320843924 tdyas/fix-dep-validator-issue Merge bbe74a2c6 into 7ea655ba0 Pull #23121 web-flow github
92.79
26317467705 arm64_on_depot Merge 6fbd9bd53 into 7ea655ba0 Pull #23363 web-flow github
92.79
26260896988 uv/venvopt Merge 0780a2281 into 7ea655ba0 Pull #23365 web-flow github
92.79
See All Builds (12669)