Coveralls logob
Coveralls logo
  • Home
  • Features
  • Pricing
  • Docs
  • Sign In

pantsbuild / pants
74%
master: 92%

DEFAULT BRANCH: master
Build:
LAST BUILD BRANCH: jsirois/issues/4692
Repo Added 31 Aug 2014 03:34PM UTC
Total Files 356
# Builds 8804 Last
Badge
Pants 1.2 Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH twitter/pants-1.2.6
branch: twitter/pants-1.2.6
CHANGE BRANCH
x
Reset
  • twitter/pants-1.2.6
  • master
  • add_transitive_jar_deps
  • lahosken/docsitegen_begin
  • areitz/add_publish_plugins
  • tdesai/fix_perf_issue
  • git-root
  • cyclic-dep
  • zundel/doc-fork-and-ci
  • options
  • tdesai/test_scalac_compiler_issues
  • tdesai/feature_javasources
  • tdesai/fix_pants_script_in_non_dev_mode
  • tdesai/pants_plugin_integrationtest
  • tdesai/add_target_type_to_depmap
  • release_0.0.26
  • scala-version
  • tdesai/twitter-release-fix
  • dturner/fix-bad-random
  • release_0.0.28
  • show
  • dturner/allow-exclude-in-globs
  • stuhood/switch-classpath-to-union-product
  • stuhood/zinc-in-platform-version
  • release_0.0.29
  • stuhood/avoid-reparsing-analysis
  • release_0.0.30
  • stuhood/jvm-compile-isolated-strategy
  • release_0.0.31
  • release_0.0.32
  • stuhood/skip-missing-depfile
  • dturner/fixit-resource-mapping-fmt
  • stuhood/1396-and-1400-integration
  • stuhood/1396-and-1395
  • stuhood/1396-and-1395-with-redundant-resources-fix
  • stuhood/isolation-integration-two
  • stuhood/deep-analysis-validation
  • stuhood/isolation-integration-three
  • stuhood/perf-integration
  • stuhood/invalidate-bad-cached-analysis
  • release_0.0.33
  • zundel/fixup-changelog
  • zundel/javadoc-fixes
  • zundel/update-junit-runner-0.0.8
  • zundel/zinc-error-output-repro
  • release_0.0.34
  • twitter/pants-1.2.3
  • release_0.0.35
  • twitter/pants-1.2.4
  • release_0.0.36
  • stuhood/missing-product-debug
  • release_0.0.37
  • stuhood/rewind
  • release_0.0.38
  • stuhood/pants-1.2.4-sans-process-edits
  • release_0.0.40
  • release_0.0.41
  • release_0.0.42
  • areitz/fix_publish_dup_options2
  • release_0.0.43
  • release_0.0.44
  • stuhood/test-populate-products
  • release_0.0.45
  • release_0.0.46
  • release_0.0.47
  • release_0.0.48
  • stuhood/no-classes-for-target
  • filedeps_v2engine

24 Aug 2015 - 20:24 coverage increased (+0.2%) to 74.068%
6386

push

travis-ci

E0fc9b4406153b561c95bbf41c36d70d?size=18&default=identiconstuhood
Add a just-in-time check of the artifact cache to the isolated compile strategy

Now that we have a single large chunk arriving in ZincCompile, the `self.invalidated` block for compilation will do a single upfront check for all cache entries (thousands potentially), and then begin compiling them, without ever checking the cache again.

In the future, pushing the invalidation check down into the `work` function that runs the compilation could be the cleanest solution. But currently I would be concerned by threadsafety in the build invalidator and elsewhere. Instead, this patch adds a double-check of the cache inside the work function.

- Add a double check of the cache to the isolated strategy immediately before beginning to compile.

Testing Done:
https://github.com/pantsbuild/pants/pull/2052

Reviewed at https://rbcommons.com/s/twitter/r/2690/

16035 of 21649 relevant lines covered (74.07%)

1.4 hits per line

Relevant lines Covered
21649 RELEVANT LINES 16035 COVERED LINES
Build:
1.4 HITS PER LINE
Source Files on twitter/pants-1.2.6
  • List 356
  • Changed 59
  • Source Changed 29
  • Coverage Changed 53
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent Builds

Builds Branch Coverage Commit Committer Type Time Via
6386 twitter/pants-1.2.6
74.07
Add a just-in-time check of the artifact cache to the isolated compile strategy Now that we have a single large chunk arriving in ZincCompile, the `self.invalidated` block for compilation will do a single upfront check for all cache entries (thou... E0fc9b4406153b561c95bbf41c36d70d?size=18&default=identiconstuhood push 24 Aug 2015 08:50PM UTC travis-ci
6375 twitter/pants-1.2.6
73.87
Add a just-in-time check of the artifact cache to the isolated compile strategy Now that we have a single large chunk arriving in ZincCompile, the `self.invalidated` block for compilation will do a single upfront check for all cache entries (thou... E0fc9b4406153b561c95bbf41c36d70d?size=18&default=identiconstuhood push 24 Aug 2015 01:09AM UTC travis-ci
6249 twitter/pants-1.2.6
73.9
Fixed no attribute exception in changed goal After testing a recent change to changed goal it appeared spec is None sometimes. Testing Done: https://travis-ci.org/fkorotkov/pants/builds/75943231 Bugs closed: 2006 Reviewed at https://rbcommons.... E0fc9b4406153b561c95bbf41c36d70d?size=18&default=identiconstuhood push 18 Aug 2015 01:53AM UTC travis-ci
See All Builds (8803)
Notice exc

Badge your Repo: pants

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.

Could not find badge in README.

Pants 1.2
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Loading Refresh
  • Repo on GitHub
Troubleshooting · Open an Issue · Sales · Support · ENTERPRISE · CAREERS · STATUS
BLOG · TWITTER · Legal & Privacy · Supported CI Services · What's a CI service? · Automated Testing

© 2019 Coveralls, LLC