pantsbuild / pants

74%

master: 0%

LAST BUILD ON BRANCH twitter/pants-1.2.6

branch: twitter/pants-1.2.6

CHANGE BRANCH

x

Reset

• twitter/pants-1.2.6
• master
• add_transitive_jar_deps
• lahosken/docsitegen_begin
• areitz/add_publish_plugins
• tdesai/fix_perf_issue
• git-root
• cyclic-dep
• zundel/doc-fork-and-ci
• options
• tdesai/test_scalac_compiler_issues
• tdesai/feature_javasources
• tdesai/fix_pants_script_in_non_dev_mode
• tdesai/pants_plugin_integrationtest
• tdesai/add_target_type_to_depmap
• release_0.0.26
• scala-version
• tdesai/twitter-release-fix
• dturner/fix-bad-random
• release_0.0.28
• show
• dturner/allow-exclude-in-globs
• stuhood/switch-classpath-to-union-product
• stuhood/zinc-in-platform-version
• release_0.0.29
• stuhood/avoid-reparsing-analysis
• release_0.0.30
• stuhood/jvm-compile-isolated-strategy
• release_0.0.31
• release_0.0.32
• stuhood/skip-missing-depfile
• dturner/fixit-resource-mapping-fmt
• stuhood/1396-and-1400-integration
• stuhood/1396-and-1395
• stuhood/1396-and-1395-with-redundant-resources-fix
• stuhood/isolation-integration-two
• stuhood/deep-analysis-validation
• stuhood/isolation-integration-three
• stuhood/perf-integration
• stuhood/invalidate-bad-cached-analysis
• release_0.0.33
• zundel/fixup-changelog
• zundel/javadoc-fixes
• zundel/update-junit-runner-0.0.8
• zundel/zinc-error-output-repro
• release_0.0.34
• twitter/pants-1.2.3
• release_0.0.35
• twitter/pants-1.2.4
• release_0.0.36
• stuhood/missing-product-debug
• release_0.0.37
• stuhood/rewind
• release_0.0.38
• stuhood/pants-1.2.4-sans-process-edits
• release_0.0.40
• release_0.0.41
• release_0.0.42
• areitz/fix_publish_dup_options2
• release_0.0.43
• release_0.0.44
• stuhood/test-populate-products
• release_0.0.45
• release_0.0.46
• release_0.0.47
• release_0.0.48
• stuhood/no-classes-for-target
• filedeps_v2engine
• release_2.0.0.dev4
• release_2.0.0.dev5
• release_2.0.0.dev6

Build # 6386

Build Type

push

travis-ci

Committed by stuhood

Commit Message

Add a just-in-time check of the artifact cache to the isolated compile strategy

Now that we have a single large chunk arriving in ZincCompile, the `self.invalidated` block for compilation will do a single upfront check for all cache entries (thousands potentially), and then begin compiling them, without ever checking the cache again.

In the future, pushing the invalidation check down into the `work` function that runs the compilation could be the cleanest solution. But currently I would be concerned by threadsafety in the build invalidator and elsewhere. Instead, this patch adds a double-check of the cache inside the work function.

- Add a double check of the cache to the isolated strategy immediately before beginning to compile.

Testing Done:
https://github.com/pantsbuild/pants/pull/2052

Reviewed at https://rbcommons.com/s/twitter/r/2690/

Run Details

16035 of 21649 relevant lines covered (74.07%)

1.4 hits per line