pantsbuild / pants
93%

DEFAULT BRANCH: main
Repo Added
Files 1757
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: main
CHANGE BRANCH
x

coverage: 92.795% (+0.005%) from 92.79%
27584169499

push

github

web-flow 
Fix derived interpreter constraints for root target (#23419)

Fixes #23418.

  ## Problem

When `[python].default_to_resolve_interpreter_constraints` is enabled,
`validate_python_dependencies` should derive a target's default
interpreter constraints from its configured Python resolve when the
  target does not set `interpreter_constraints` directly.

The dependency side already did this correctly by reading
`PythonResolveField` directly from each dependency target. The root
target being validated did not: `DependencyValidationFieldSet` declared
`resolve` as `PythonResolveField | None`, and `FieldSet.create()` only
populates attributes whose annotation is a direct `Field` subclass.
Because the union annotation was ignored, the field set kept the
dataclass default of `None`, causing the root target to fall back to
global Python interpreter constraints instead of the resolve-derived
constraints.

That made validation asymmetric: the root target used global interpreter
constraints, while dependencies used resolve-derived interpreter
constraints.

  ## Solution

Change `DependencyValidationFieldSet.resolve` to be a direct
`PythonResolveField` annotation so `FieldSet.create()` includes it.
`PythonResolveField` remains optional for dependency validation because
it
is not part of `required_fields`; this preserves the existing FieldSet
optional-field pattern while allowing resolve-capable Python targets to
carry their actual resolve into validation.

The tests now cover manual interpreter constraint validation, explicit
target interpreter constraints overriding resolve defaults, and the
resolve-derived default case that reproduces the issue.

36 of 36 new or added lines in 2 files covered. (100.0%)

93175 of 100410 relevant lines covered (92.79%)

3.69 hits per line

Relevant lines Covered
100410 RELEVANT LINES 93175 COVERED LINES
3.69 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
27584169499 main Fix derived interpreter constraints for root target (#23419) Fixes #23418. ## Problem When `[python].default_to_resolve_interpreter_constraints` is enabled, `validate_python_dependencies` should derive a target's default interpreter constrain... push web-flow github
92.79
27417451381 main Prepare 2.33.0.dev3 (#23423) Co-authored-by: Worker Pants (Pantsbuild GitHub Automation Bot) <pantsbuild+github-automation@gmail.com> push web-flow github
92.79
27288550557 main Fix sync for lockfiles with metadata headers. (#23413) Previously, attemping to `--sync` a lockfile with metadata headers would error. Fixes #23398 As a reminder: `--sync` does a minimal lockfile update, keeping as many requirements fixed as po... push web-flow github
92.79
27287295740 main Raise the minimum supported pex version to 2.95.1. (#23412) This version contains features and fixes required by uv support. Folks pinning to an earlier version of pex will have to upgrade. Pex is very scrupulous about backwards compatibility, s... push web-flow github
92.79
27221107514 main Fix PBS provider returning host path inside `docker_environment` (#23384) Resolve the interpreter path inside the install process via `realpath` and echo it on stdout, so the caller picks up whichever path actually exists in the environment the p... push web-flow github
92.79
27118289758 main Fix uv support under remote caching/execution. (#23403) As explained in #23344, a remote cache hit on the process that creates the uv venv will cause venv creation to be skipped, and pex will not find that venv locally. With this change uv venv ... push web-flow github
92.79
27079234648 main Compose a Process out of multiple sequential subprocesses (#23400) It is sometimes useful to run multiple processes in a single Process invocation. For example, when creating a pex from a venv repository, we need to ensure the venv repository e... push web-flow github
92.79
26942703638 main Perf: SourceField, PathGlobs and Filespec in rust (#23244) ```console hyperfine --warmup 1 -n 'main' 'PYENV_VERSION=pants@3.14.3 PANTS_SOURCE=/tmp/pants-main pants --no-pantsd dependencies ::' -n 'add/source-field-in-rust' 'PYENV_VERSION=pants@3.... push web-flow github
92.78
26801113862 main Upgrade RunsOn AMI to ami-0a3c71582153db678 (#23397) push web-flow github
92.79
26764227497 main rust dockerfile parser build arg parity with python parser (#23392) Closes https://github.com/pantsbuild/pants/issues/22443 push web-flow github
92.79
See All Builds (12781)