2
0%
main: 91%

Ran 18 Sep 2015 06:13PM UTC

Files 394

Run time 11s

Badge

Embed ▾

Committed 18 Sep 2015 05:53PM UTC coverage: 71.139%. Remained the same

Job # CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'"

Build Type

push

travis-ci

Committed by

baroquebobcat

Commit Message

Use list comprehension in jvm_compile to calculate valid targets

While looking at vts usages when adjusting buildcache for adding the cache hit callback, I noticed that we are doing extra work here.

Instead of doing set math with relevant_targets and invalid_targets, this creates a list from the all_vts' targets, removing the invalid ones. all_vts in this context maps onto relevant_targets, so they are equivalent but I think this is simpler and creates fewer intermediate objects / operations.

Testing Done:
CI away at https://travis-ci.org/pantsbuild/pants/builds/81050720 . I ran some integration tests locally and had both implementations with an assert containing an equality check. I would have expected the assert to blow up if my assumptions were incorrect.

Bugs closed: 2216

Reviewed at https://rbcommons.com/s/twitter/r/2843/

Coverage Stats

16838 of 23669 relevant lines covered (71.14%)

0.71 hits per line

pantsbuild / pants / 6929 / 2
0%
main: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6929.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")

pantsbuild / pants / 6929 / 2 0% main: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6929.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")

pantsbuild / pants / 6929 / 2
0%
main: 91%

README BADGES
x