pantsbuild / pants / 6929

0%

main: 93%

push

travis-ci

Use list comprehension in jvm_compile to calculate valid targets

While looking at vts usages when adjusting buildcache for adding the cache hit callback, I noticed that we are doing extra work here.

Instead of doing set math with relevant_targets and invalid_targets, this creates a list from the all_vts' targets, removing the invalid ones. all_vts in this context maps onto relevant_targets, so they are equivalent but I think this is simpler and creates fewer intermediate objects / operations.

Testing Done:
CI away at https://travis-ci.org/pantsbuild/pants/builds/81050720 . I ran some integration tests locally and had both implementations with an assert containing an equality check. I would have expected the assert to blow up if my assumptions were incorrect.

Bugs closed: 2216

Reviewed at https://rbcommons.com/s/twitter/r/2843/

1 of 1 new or added line in 1 file covered. (100.0%)

17892 of 23669 relevant lines covered (75.59%)

1.43 hits per line