2
0%
main: 93%

Ran 14 Sep 2015 12:34AM UTC

Files 391

Run time 98min

Badge

Embed ▾

Committed 14 Sep 2015 12:27AM UTC coverage: 70.924% (-0.03%) from 70.953%

Job # CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'"

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Add a just-in-time check of the artifact cache to the isolated compile strategy

Now that we have a single large chunk arriving in ZincCompile, the `self.invalidated` block for compilation will do a single upfront check for all cache entries (thousands potentially), and then begin compiling them, without ever checking the cache again.

In the future, pushing the invalidation check down into the `work` function that runs the compilation could be the cleanest solution. But currently I would be concerned by threadsafety in the build invalidator and elsewhere. Instead, this patch adds a double-check of the cache inside the work function.

- Add a double check of the cache to the isolated strategy immediately before beginning to compile.

Testing Done:
https://github.com/pantsbuild/pants/pull/2052

Reviewed at https://rbcommons.com/s/twitter/r/2690/

Coverage Stats

16670 of 23504 relevant lines covered (70.92%)

0.71 hits per line

pantsbuild / pants / 6826 / 2
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6826.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")

pantsbuild / pants / 6826 / 2 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6826.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")

pantsbuild / pants / 6826 / 2
0%
main: 93%

README BADGES
x