6826
0%
main: 93%

Ran 14 Sep 2015 12:33AM UTC

Jobs 10

Files 391

Run time 100min

Badge

Embed ▾

pending completion

Build # 6826

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Add a just-in-time check of the artifact cache to the isolated compile strategy

Now that we have a single large chunk arriving in ZincCompile, the `self.invalidated` block for compilation will do a single upfront check for all cache entries (thousands potentially), and then begin compiling them, without ever checking the cache again.

In the future, pushing the invalidation check down into the `work` function that runs the compilation could be the cleanest solution. But currently I would be concerned by threadsafety in the build invalidator and elsewhere. Instead, this patch adds a double-check of the cache inside the work function.

- Add a double check of the cache to the isolated strategy immediately before beginning to compile.

Testing Done:
https://github.com/pantsbuild/pants/pull/2052

Reviewed at https://rbcommons.com/s/twitter/r/2690/

Run Details

17748 of 23504 relevant lines covered (75.51%)

1.43 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	6826.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	14 Sep 2015 12:33AM UTC		Travis Job 6826.1
2	6826.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	14 Sep 2015 12:34AM UTC	70.92	Travis Job 6826.2
3	6826.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	14 Sep 2015 12:34AM UTC	71.63	Travis Job 6826.3
4	6826.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	14 Sep 2015 12:34AM UTC		Travis Job 6826.4
5	6826.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	14 Sep 2015 12:35AM UTC		Travis Job 6826.5
6	6826.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	14 Sep 2015 12:39AM UTC		Travis Job 6826.6
7	6826.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	14 Sep 2015 12:43AM UTC		Travis Job 6826.7
8	6826.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	14 Sep 2015 12:41AM UTC		Travis Job 6826.8
9	6826.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	14 Sep 2015 12:40AM UTC		Travis Job 6826.9
10	6826.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	14 Sep 2015 12:39AM UTC		Travis Job 6826.10

Source Files on build 6826

Detailed source file information is not available for this build.

pantsbuild / pants / 6826
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6826

pantsbuild / pants / 6826 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6826

pantsbuild / pants / 6826
0%
main: 93%

README BADGES
x