2
0%
main: 93%

Ran 10 Sep 2015 07:59PM UTC

Files 388

Run time 1min

Badge

Embed ▾

Committed 10 Sep 2015 07:52PM UTC coverage: 71.153% (-0.2%) from 71.361%

Job # CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'"

Build Type

push

travis-ci

Committed by

jsirois

Commit Message

Move BuildFileAliases validation to BuildFileAliases.

Previously, alias mappings were validated by BuildConfiguration.  Doing
the validation in BuilfFileAliases ensures only valid objects are
constructed and never float around in an invalid state and it
centralizes the mostly internal detail that "targets" contains a mix of
types, allowing the mix to be split and presented via seperate
properties.

This adds TargetMacro.Factory coverage to BuildConfigurationTest while
moving its validation tests over to BuilfFileAliasesTest.

The change also forces existing users of BuilfFileAliases.targets to
deal with BuilfFileAliases.target_types and
BuilfFileAliases.target_macro_factories.  To help those users a few
utility methods are added to BuildFileAliases to unify target types
accessed via these two properties.

Testing Done:
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/79719489

Bugs closed: 2124, 2160

Reviewed at https://rbcommons.com/s/twitter/r/2790/

Coverage Stats

16652 of 23403 relevant lines covered (71.15%)

0.71 hits per line

pantsbuild / pants / 6786 / 2
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6786.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")

pantsbuild / pants / 6786 / 2 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6786.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")

pantsbuild / pants / 6786 / 2
0%
main: 93%

README BADGES
x