6786
0%
main: 93%

Ran 10 Sep 2015 07:58PM UTC

Jobs 10

Files 388

Run time 13min

Badge

Embed ▾

pending completion

Build # 6786

Build Type

push

travis-ci

Committed by

jsirois

Commit Message

Move BuildFileAliases validation to BuildFileAliases.

Previously, alias mappings were validated by BuildConfiguration.  Doing
the validation in BuilfFileAliases ensures only valid objects are
constructed and never float around in an invalid state and it
centralizes the mostly internal detail that "targets" contains a mix of
types, allowing the mix to be split and presented via seperate
properties.

This adds TargetMacro.Factory coverage to BuildConfigurationTest while
moving its validation tests over to BuilfFileAliasesTest.

The change also forces existing users of BuilfFileAliases.targets to
deal with BuilfFileAliases.target_types and
BuilfFileAliases.target_macro_factories.  To help those users a few
utility methods are added to BuildFileAliases to unify target types
accessed via these two properties.

Testing Done:
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/79719489

Bugs closed: 2124, 2160

Reviewed at https://rbcommons.com/s/twitter/r/2790/

Run Details

17670 of 23403 relevant lines covered (75.5%)

1.43 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	6786.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	10 Sep 2015 08:04PM UTC		Travis Job 6786.1
2	6786.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	10 Sep 2015 07:59PM UTC	71.15	Travis Job 6786.2
3	6786.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	10 Sep 2015 08:00PM UTC	71.55	Travis Job 6786.3
4	6786.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	10 Sep 2015 07:58PM UTC		Travis Job 6786.4
5	6786.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	10 Sep 2015 07:59PM UTC		Travis Job 6786.5
6	6786.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	10 Sep 2015 08:05PM UTC		Travis Job 6786.6
7	6786.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	10 Sep 2015 08:06PM UTC		Travis Job 6786.7
8	6786.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	10 Sep 2015 08:05PM UTC		Travis Job 6786.8
9	6786.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	10 Sep 2015 08:07PM UTC		Travis Job 6786.9
10	6786.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	10 Sep 2015 08:11PM UTC		Travis Job 6786.10

Source Files on build 6786

Detailed source file information is not available for this build.

pantsbuild / pants / 6786
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6786

pantsbuild / pants / 6786 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6786

pantsbuild / pants / 6786
0%
main: 93%

README BADGES
x