2
0%
main: 64%

Ran 08 Sep 2015 04:41PM UTC

Files 386

Run time 18s

Badge

Embed ▾

Committed 08 Sep 2015 04:34PM UTC coverage: 70.536% (+0.004%) from 70.532%

Job # CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'"

Build Type

push

travis-ci

Committed by

patricklaw

Commit Message

Plumb bytes to zincutils rebase interface [BUGFIX]

zincutils optimizes analysis parsing in a way that requires bytes-only
string replacement operations.  Zinc analysis with non-ascii symbols
will fail in some circumstances when the placeholder directory strings
passed into the parser object are not strictly bytes.  This change
ensures that bytes-only directory structures are passed to the `rebase`
method by utf-8 encoding the buildroot and setting the
`AnalysisTools._PANTS_HOME_PLACEHOLDER` constant to be a `bytes` type
rather than a "text" string.

Testing Done:
Add a test for this particular failure and flip on name_hashing
in pants.isolated.ini.  Confirmed the test fails (with a hack to
check stdout for "FAILURE", because currently we don't actually
fail on cache write failures, for good reason).  The test passes
after the fix.

CI green: https://travis-ci.org/pantsbuild/pants/builds/78854681

Bugs closed: 2140

Reviewed at https://rbcommons.com/s/twitter/r/2776/

Coverage Stats

16243 of 23028 relevant lines covered (70.54%)

0.71 hits per line

pantsbuild / pants / 6736 / 2
0%
main: 64%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6736.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")

pantsbuild / pants / 6736 / 2 0% main: 64%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6736.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")

pantsbuild / pants / 6736 / 2
0%
main: 64%

README BADGES
x