6736
0%
main: 93%

Ran 08 Sep 2015 04:41PM UTC

Jobs 9

Files 386

Run time 10min

Badge

Embed ▾

pending completion

Build # 6736

Build Type

push

travis-ci

Committed by

patricklaw

Commit Message

Plumb bytes to zincutils rebase interface [BUGFIX]

zincutils optimizes analysis parsing in a way that requires bytes-only
string replacement operations.  Zinc analysis with non-ascii symbols
will fail in some circumstances when the placeholder directory strings
passed into the parser object are not strictly bytes.  This change
ensures that bytes-only directory structures are passed to the `rebase`
method by utf-8 encoding the buildroot and setting the
`AnalysisTools._PANTS_HOME_PLACEHOLDER` constant to be a `bytes` type
rather than a "text" string.

Testing Done:
Add a test for this particular failure and flip on name_hashing
in pants.isolated.ini.  Confirmed the test fails (with a hack to
check stdout for "FAILURE", because currently we don't actually
fail on cache write failures, for good reason).  The test passes
after the fix.

CI green: https://travis-ci.org/pantsbuild/pants/builds/78854681

Bugs closed: 2140

Reviewed at https://rbcommons.com/s/twitter/r/2776/

Run Details

17341 of 23028 relevant lines covered (75.3%)

1.42 hits per line

Jobs

ID	Job ID	Ran	Coverage
2	6736.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	08 Sep 2015 04:41PM UTC	70.54	Travis Job 6736.2
3	6736.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	08 Sep 2015 04:43PM UTC	71.42	Travis Job 6736.3
4	6736.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	08 Sep 2015 04:41PM UTC		Travis Job 6736.4
5	6736.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	08 Sep 2015 04:46PM UTC		Travis Job 6736.5
6	6736.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	08 Sep 2015 04:48PM UTC		Travis Job 6736.6
7	6736.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	08 Sep 2015 04:47PM UTC		Travis Job 6736.7
8	6736.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	08 Sep 2015 04:50PM UTC		Travis Job 6736.8
9	6736.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	08 Sep 2015 04:50PM UTC		Travis Job 6736.9
10	6736.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	08 Sep 2015 04:52PM UTC		Travis Job 6736.10

Source Files on build 6736

Detailed source file information is not available for this build.

pantsbuild / pants / 6736
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6736

pantsbuild / pants / 6736 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6736

pantsbuild / pants / 6736
0%
main: 93%

README BADGES
x