3
0%
main: 93%

Ran 04 Sep 2015 09:40PM UTC

Files 386

Run time 16s

Badge

Embed ▾

Committed 04 Sep 2015 09:29PM UTC coverage: 70.885%. Remained the same

Job # CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'"

Build Type

push

travis-ci

Committed by

gmalmquist

Commit Message

Eliminated duplicate jar entries caused by consecutive slashes.

We noticed this duplication in some of our internal jar builds. It
mostly doesn't cause any problems, but was breaking jarjar when it
tried to shade them (for rb 2754).

Despite only having one version of the class most of the way
through the jar building pipeline, duplicate classes were
artificially created due to a bug in the path calculation for the
jar entry.

Specifically, we create the final jar entry path by calling 'join'
on the path separator ('/') over an iterable of path components,
however it appears there are some cases where the path components
may contain trailing slashes.

Internally, this resulted in .jar files with entries that looked
like:

    com/squareup/foo/bar/app/package/File.class
    com//squareup/foo/bar/app/package/File.class
    com/squareup//foo/bar/app/package/File.class
    com/squareup/foo//bar/app/package/File.class
    com/squareup/foo/bar//app/package/File.class
    com/squareup/foo/bar/app//package/File.class
    com/squareup/foo/bar/app/package//File.class

This is a very simple (but subtle) bug, and the fix is similarly
simple.

Testing Done:
CI went green: https://travis-ci.org/pantsbuild/pants/builds/78817173

Bugs closed: 2131

Reviewed at https://rbcommons.com/s/twitter/r/2763/

Run Details

16322 of 23026 relevant lines covered (70.89%)

0.71 hits per line

pantsbuild / pants / 6671 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6671.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 6671 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6671.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 6671 / 3
0%
main: 93%

README BADGES
x