6671
0%
main: 93%

Ran 04 Sep 2015 09:35PM UTC

Jobs 10

Files 386

Run time 11min

Badge

Embed ▾

pending completion

Build # 6671

Build Type

push

travis-ci

Committed by

gmalmquist

Commit Message

Eliminated duplicate jar entries caused by consecutive slashes.

We noticed this duplication in some of our internal jar builds. It
mostly doesn't cause any problems, but was breaking jarjar when it
tried to shade them (for rb 2754).

Despite only having one version of the class most of the way
through the jar building pipeline, duplicate classes were
artificially created due to a bug in the path calculation for the
jar entry.

Specifically, we create the final jar entry path by calling 'join'
on the path separator ('/') over an iterable of path components,
however it appears there are some cases where the path components
may contain trailing slashes.

Internally, this resulted in .jar files with entries that looked
like:

    com/squareup/foo/bar/app/package/File.class
    com//squareup/foo/bar/app/package/File.class
    com/squareup//foo/bar/app/package/File.class
    com/squareup/foo//bar/app/package/File.class
    com/squareup/foo/bar//app/package/File.class
    com/squareup/foo/bar/app//package/File.class
    com/squareup/foo/bar/app/package//File.class

This is a very simple (but subtle) bug, and the fix is similarly
simple.

Testing Done:
CI went green: https://travis-ci.org/pantsbuild/pants/builds/78817173

Bugs closed: 2131

Reviewed at https://rbcommons.com/s/twitter/r/2763/

Run Details

17339 of 23026 relevant lines covered (75.3%)

1.42 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	6671.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	04 Sep 2015 09:36PM UTC		Travis Job 6671.1
2	6671.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	04 Sep 2015 09:36PM UTC	70.95	Travis Job 6671.2
3	6671.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	04 Sep 2015 09:40PM UTC	70.89	Travis Job 6671.3
4	6671.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	04 Sep 2015 09:35PM UTC		Travis Job 6671.4
5	6671.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	04 Sep 2015 09:38PM UTC		Travis Job 6671.5
6	6671.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	04 Sep 2015 09:42PM UTC		Travis Job 6671.6
7	6671.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	04 Sep 2015 09:43PM UTC		Travis Job 6671.7
8	6671.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	04 Sep 2015 09:45PM UTC		Travis Job 6671.8
9	6671.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	04 Sep 2015 09:45PM UTC		Travis Job 6671.9
10	6671.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	04 Sep 2015 09:46PM UTC		Travis Job 6671.10

Source Files on build 6671

Detailed source file information is not available for this build.

pantsbuild / pants / 6671
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6671

pantsbuild / pants / 6671 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6671

pantsbuild / pants / 6671
0%
main: 93%

README BADGES
x