3
0%
main: 93%

Ran 03 Sep 2015 07:01PM UTC

Files 383

Run time 11s

Badge

Embed ▾

Committed 03 Sep 2015 06:51PM UTC coverage: 70.978% (-0.007%) from 70.985%

Job # CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'"

Build Type

push

travis-ci

Committed by Kris Wilson

Commit Message

Normalize and decompose GoalRunner initialization and setup

Pre-emptive cleanup of GoalRunner and friends. Thinking this will make it easier to implement (and review) some upcoming changes and generally improves readability/modability.

- Remove {BuildFileParser,BuildGraph}.run_tracker (both currently unused AFAICT) in support of cleaner BuildGraph serialization
- Migrate all attribute initialization to __init__()
- Move options_bootstrapper and working_set params from setup() -> __init__() and default them
- Decompose setup() and expand_goals_and_specs() into slightly smaller, more purposeful methods
- Misc readability/consistency/style cleanups

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/77429262

-----------------------------

```
$ PANTS_DEV=1 ./pants clean-all compile testprojects/src/java/org/pantsbuild/testproject/javasources/::
...
               SUCCESS
```

Bugs closed: 2078

Reviewed at https://rbcommons.com/s/twitter/r/2715/

Coverage Stats

16239 of 22879 relevant lines covered (70.98%)

0.71 hits per line

pantsbuild / pants / 6628 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6628.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 6628 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6628.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 6628 / 3
0%
main: 93%

README BADGES
x