6628
0%
main: 93%

Ran 03 Sep 2015 06:57PM UTC

Jobs 10

Files 383

Run time 10min

Badge

Embed ▾

pending completion

Build # 6628

Build Type

push

travis-ci

Committed by Kris Wilson

Commit Message

Normalize and decompose GoalRunner initialization and setup

Pre-emptive cleanup of GoalRunner and friends. Thinking this will make it easier to implement (and review) some upcoming changes and generally improves readability/modability.

- Remove {BuildFileParser,BuildGraph}.run_tracker (both currently unused AFAICT) in support of cleaner BuildGraph serialization
- Migrate all attribute initialization to __init__()
- Move options_bootstrapper and working_set params from setup() -> __init__() and default them
- Decompose setup() and expand_goals_and_specs() into slightly smaller, more purposeful methods
- Misc readability/consistency/style cleanups

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/77429262

-----------------------------

```
$ PANTS_DEV=1 ./pants clean-all compile testprojects/src/java/org/pantsbuild/testproject/javasources/::
...
               SUCCESS
```

Bugs closed: 2078

Reviewed at https://rbcommons.com/s/twitter/r/2715/

Run Details

17196 of 22879 relevant lines covered (75.16%)

1.42 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	6628.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	03 Sep 2015 06:59PM UTC		Travis Job 6628.1
2	6628.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	03 Sep 2015 06:58PM UTC	70.62	Travis Job 6628.2
3	6628.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	03 Sep 2015 07:01PM UTC	70.98	Travis Job 6628.3
4	6628.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	03 Sep 2015 06:57PM UTC		Travis Job 6628.4
5	6628.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	03 Sep 2015 06:58PM UTC		Travis Job 6628.5
6	6628.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	03 Sep 2015 07:04PM UTC		Travis Job 6628.6
7	6628.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	03 Sep 2015 07:06PM UTC		Travis Job 6628.7
8	6628.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	03 Sep 2015 07:05PM UTC		Travis Job 6628.8
9	6628.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	03 Sep 2015 07:04PM UTC		Travis Job 6628.9
10	6628.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	03 Sep 2015 07:07PM UTC		Travis Job 6628.10

Source Files on build 6628

Detailed source file information is not available for this build.

pantsbuild / pants / 6628
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6628

pantsbuild / pants / 6628 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6628

pantsbuild / pants / 6628
0%
main: 93%

README BADGES
x