pantsbuild / pants / 6583 / 2
0%
main: 93%

LAST BUILD BRANCH: dependabot/github_actions/gha-deps-7ba3178b21
DEFAULT BRANCH: main
Ran
Files 381
Run time 26s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 69.928% (+0.02%) from 69.91%
CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'"

push

travis-ci

John Sirois 
Make nailgun killing faster.

- Lift and simplify twitter.common.concurrent.deadline + a add couple of related helpers into pants.util.deadline
- Speed up ProcessManager.terminate() by using a deadline approach vs fixed sleep (addresses #2015)
- Tests

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/76723332

-----------------------------------------------------------------

benchmark (primed via `PANTS_DEV=1 ./pants clean-all compile testprojects/src/java/org/pantsbuild/testproject/javasources/::`)

before:

    [illuminati pants (master)]$ time ./pants ng-killall
    ...
    17:29:04 00:01     [ng-killall]
    INFO] killing nailgun server pid=44791
    INFO] killing nailgun server pid=44793
    INFO] killing nailgun server pid=44807
    INFO] killing nailgun server pid=44810
    INFO] killing nailgun server pid=44812

    17:29:09 00:06   [complete]
                   SUCCESS

    real  0m6.190s
    user  0m0.600s
    sys   0m0.226s

after:

    [illuminati pants (kwlzn/nailgun_term)]$ time ./pants ng-killall
    ...
    17:27:06 00:00     [ng-killall]
    INFO] killing nailgun server pid=44623
    INFO] killing nailgun server pid=44629
    INFO] killing nailgun server pid=44643
    INFO] killing nailgun server pid=44646
    INFO] killing nailgun server pid=44648

    17:27:06 00:00   [complete]
                   SUCCESS

    real  0m1.161s
    user  0m0.626s
    sys   0m0.266s

Bugs closed: 2015, 2040

Reviewed at https://rbcommons.com/s/twitter/r/2685/

15859 of 22679 relevant lines covered (69.93%)

0.7 hits per line

Source Files on job 6583.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")