6583
0%
main: 93%

Ran 01 Sep 2015 03:10AM UTC

Jobs 10

Files 381

Run time 14min

Badge

Embed ▾

pending completion

Build # 6583

Build Type

push

travis-ci

Committed by John Sirois

Commit Message

Make nailgun killing faster.

- Lift and simplify twitter.common.concurrent.deadline + a add couple of related helpers into pants.util.deadline
- Speed up ProcessManager.terminate() by using a deadline approach vs fixed sleep (addresses #2015)
- Tests

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/76723332

-----------------------------------------------------------------

benchmark (primed via `PANTS_DEV=1 ./pants clean-all compile testprojects/src/java/org/pantsbuild/testproject/javasources/::`)

before:

    [illuminati pants (master)]$ time ./pants ng-killall
    ...
    17:29:04 00:01     [ng-killall]
    INFO] killing nailgun server pid=44791
    INFO] killing nailgun server pid=44793
    INFO] killing nailgun server pid=44807
    INFO] killing nailgun server pid=44810
    INFO] killing nailgun server pid=44812

    17:29:09 00:06   [complete]
                   SUCCESS

    real  0m6.190s
    user  0m0.600s
    sys   0m0.226s

after:

    [illuminati pants (kwlzn/nailgun_term)]$ time ./pants ng-killall
    ...
    17:27:06 00:00     [ng-killall]
    INFO] killing nailgun server pid=44623
    INFO] killing nailgun server pid=44629
    INFO] killing nailgun server pid=44643
    INFO] killing nailgun server pid=44646
    INFO] killing nailgun server pid=44648

    17:27:06 00:00   [complete]
                   SUCCESS

    real  0m1.161s
    user  0m0.626s
    sys   0m0.266s

Bugs closed: 2015, 2040

Reviewed at https://rbcommons.com/s/twitter/r/2685/

Run Details

16993 of 22679 relevant lines covered (74.93%)

1.41 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	6583.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	01 Sep 2015 03:10AM UTC		Travis Job 6583.1
2	6583.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	01 Sep 2015 03:14AM UTC	69.93	Travis Job 6583.2
3	6583.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	01 Sep 2015 03:15AM UTC	71.06	Travis Job 6583.3
4	6583.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	01 Sep 2015 03:14AM UTC		Travis Job 6583.4
5	6583.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	01 Sep 2015 03:16AM UTC		Travis Job 6583.5
6	6583.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	01 Sep 2015 03:22AM UTC		Travis Job 6583.6
7	6583.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	01 Sep 2015 03:21AM UTC		Travis Job 6583.7
8	6583.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	01 Sep 2015 03:21AM UTC		Travis Job 6583.8
9	6583.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	01 Sep 2015 03:20AM UTC		Travis Job 6583.9
10	6583.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	01 Sep 2015 03:25AM UTC		Travis Job 6583.10

Source Files on build 6583

Detailed source file information is not available for this build.

pantsbuild / pants / 6583
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6583

pantsbuild / pants / 6583 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6583

pantsbuild / pants / 6583
0%
main: 93%

README BADGES
x