pantsbuild / pants / 6579 / 2
0%
main: 93%

LAST BUILD BRANCH: add/remove-python-trampoline-overhead
DEFAULT BRANCH: main
Ran
Files 381
Run time 14s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 69.919% (-0.1%) from 70.034%
CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'"

push

travis-ci

Stu Hood 
PytestRun test failures parsing is broken for tests in a class

Fix a bug in pytest_run where failures from tests in class are not parsed properly.  For tests that are inside the class, the failure line for each test failure will look like the following:
# F path/to/test_file.py::TestClassName::test_name

The regex pants uses to get the source file name was
#re.compile(r'F +(.+)::(.+)')
As a result, the file path doesn't match the source of the failing target which resulted in TestFailedTaskError always have an empty failed targets list.

Here is an example of a results log from a python test target.

. science/tests/python/twitter/mde/runner/test_check_subprocess.py::TestCheckSubprocess::()::test_check_subprocess_success
F science/tests/python/twitter/mde/runner/test_check_subprocess.py::TestCheckSubprocess::()::test_log_subprocess_failure
 self = <test_check_subprocess.TestCheckSubprocess object at 0x1072b6a10>

     def test_log_subprocess_failure(self):
       command = [
         'python',
         '-c',
         textwrap.dedent('''
             import sys
             sys.stdout.write("stdout\n")
             sys.stderr.write("stderr\n")
             sys.exit(1)''')
       ]
 >     assert 1 == 2
 E     assert 1 == 2

 science/tests/python/twitter/mde/runner/test_check_subprocess.py:24: AssertionError

Testing Done:
https://github.com/pantsbuild/pants/pull/2077

Reviewed at https://rbcommons.com/s/twitter/r/2714/

15850 of 22669 relevant lines covered (69.92%)

0.7 hits per line

Source Files on job 6579.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")