6579
0%
main: 93%

Ran 01 Sep 2015 12:07AM UTC

Jobs 10

Files 381

Run time 11min

Badge

Embed ▾

pending completion

Build # 6579

Build Type

push

travis-ci

Committed by Stu Hood

Commit Message

PytestRun test failures parsing is broken for tests in a class

Fix a bug in pytest_run where failures from tests in class are not parsed properly.  For tests that are inside the class, the failure line for each test failure will look like the following:
# F path/to/test_file.py::TestClassName::test_name

The regex pants uses to get the source file name was
#re.compile(r'F +(.+)::(.+)')
As a result, the file path doesn't match the source of the failing target which resulted in TestFailedTaskError always have an empty failed targets list.

Here is an example of a results log from a python test target.

. science/tests/python/twitter/mde/runner/test_check_subprocess.py::TestCheckSubprocess::()::test_check_subprocess_success
F science/tests/python/twitter/mde/runner/test_check_subprocess.py::TestCheckSubprocess::()::test_log_subprocess_failure
 self = <test_check_subprocess.TestCheckSubprocess object at 0x1072b6a10>

     def test_log_subprocess_failure(self):
       command = [
         'python',
         '-c',
         textwrap.dedent('''
             import sys
             sys.stdout.write("stdout\n")
             sys.stderr.write("stderr\n")
             sys.exit(1)''')
       ]
 >     assert 1 == 2
 E     assert 1 == 2

 science/tests/python/twitter/mde/runner/test_check_subprocess.py:24: AssertionError

Testing Done:
https://github.com/pantsbuild/pants/pull/2077

Reviewed at https://rbcommons.com/s/twitter/r/2714/

Run Details

16981 of 22669 relevant lines covered (74.91%)

1.41 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	6579.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	01 Sep 2015 12:07AM UTC		Travis Job 6579.1
2	6579.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	01 Sep 2015 12:08AM UTC	69.92	Travis Job 6579.2
3	6579.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	01 Sep 2015 12:09AM UTC	71.05	Travis Job 6579.3
4	6579.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	01 Sep 2015 12:08AM UTC		Travis Job 6579.4
5	6579.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	01 Sep 2015 12:12AM UTC		Travis Job 6579.5
6	6579.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	01 Sep 2015 12:13AM UTC		Travis Job 6579.6
7	6579.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	01 Sep 2015 12:16AM UTC		Travis Job 6579.7
8	6579.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	01 Sep 2015 12:15AM UTC		Travis Job 6579.8
9	6579.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	01 Sep 2015 12:14AM UTC		Travis Job 6579.9
10	6579.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	01 Sep 2015 12:18AM UTC		Travis Job 6579.10

Source Files on build 6579

Detailed source file information is not available for this build.

pantsbuild / pants / 6579
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6579

pantsbuild / pants / 6579 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6579

pantsbuild / pants / 6579
0%
main: 93%

README BADGES
x