3
0%
main: 93%

Ran 30 Aug 2015 06:32PM UTC

Files 381

Run time 15s

Badge

Embed ▾

Committed 30 Aug 2015 06:19PM UTC coverage: 70.201% (+0.006%) from 70.195%

Job # CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'"

Build Type

push

travis-ci

Committed by

patricklaw

Commit Message

Make nailgun_client error when the client socket is closed. [BUGFIX]

Previously, if the client socket was closed gracefully on
the other side (by the nailgun) while at the start or middle
of attempting to read a message from the socket, the client
would go into a hard loop attempting to do a blocking read
on the socket.  But when the socket has been closed, that
blocking read returns immediately with no bytes to indicate
that the socket is closed.

Testing Done:
Added tests to exercise the two new exception types and the
various interesting points in the message byte stream where
the server could terminate the socket.

CI is green: https://travis-ci.org/pantsbuild/pants/builds/77937754

Bugs closed: 2091

Reviewed at https://rbcommons.com/s/twitter/r/2727/

Coverage Stats

15923 of 22682 relevant lines covered (70.2%)

0.7 hits per line

pantsbuild / pants / 6521 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6521.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 6521 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6521.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 6521 / 3
0%
main: 93%

README BADGES
x