6521
0%
main: 93%

Ran 30 Aug 2015 06:29PM UTC

Jobs 10

Files 381

Run time 11min

Badge

Embed ▾

pending completion

Build # 6521

Build Type

push

travis-ci

Committed by

patricklaw

Commit Message

Make nailgun_client error when the client socket is closed. [BUGFIX]

Previously, if the client socket was closed gracefully on
the other side (by the nailgun) while at the start or middle
of attempting to read a message from the socket, the client
would go into a hard loop attempting to do a blocking read
on the socket.  But when the socket has been closed, that
blocking read returns immediately with no bytes to indicate
that the socket is closed.

Testing Done:
Added tests to exercise the two new exception types and the
various interesting points in the message byte stream where
the server could terminate the socket.

CI is green: https://travis-ci.org/pantsbuild/pants/builds/77937754

Bugs closed: 2091

Reviewed at https://rbcommons.com/s/twitter/r/2727/

Run Details

16968 of 22682 relevant lines covered (74.81%)

1.41 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	6521.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	30 Aug 2015 06:30PM UTC		Travis Job 6521.1
2	6521.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	30 Aug 2015 06:34PM UTC	70.57	Travis Job 6521.2
3	6521.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	30 Aug 2015 06:32PM UTC	70.2	Travis Job 6521.3
4	6521.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	30 Aug 2015 06:29PM UTC		Travis Job 6521.4
5	6521.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	30 Aug 2015 06:32PM UTC		Travis Job 6521.5
6	6521.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	30 Aug 2015 06:39PM UTC		Travis Job 6521.6
7	6521.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	30 Aug 2015 06:41PM UTC		Travis Job 6521.7
8	6521.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	30 Aug 2015 06:37PM UTC		Travis Job 6521.8
9	6521.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	30 Aug 2015 06:38PM UTC		Travis Job 6521.9
10	6521.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	30 Aug 2015 06:39PM UTC		Travis Job 6521.10

Source Files on build 6521

Detailed source file information is not available for this build.

pantsbuild / pants / 6521
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6521

pantsbuild / pants / 6521 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6521

pantsbuild / pants / 6521
0%
main: 93%

README BADGES
x