3
0%
main: 93%

Ran 05 Aug 2015 07:05PM UTC

Files 348

Run time 11s

Badge

Embed ▾

Committed 05 Aug 2015 06:39PM UTC coverage: 69.02% (+0.1%) from 68.925%

Job # CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'"

Build Type

push

travis-ci

Committed by

dturner-tw

Commit Message

Handle recursive globs with build-file-rev

Previously, build-file-rev with recursive globs would fail in two ways:
1. cmd_line_spec_parser would mistakenly look for the glob directory
in the filesystem even.

2. Some relative paths would contain dot components (e.g. ./foo), and
_realpath_uncached would fail to handle these.

This patch fixes both of these problems.

The recursive glob check had to move inside scan_buildfiles.  To do
so, _isdir became a classmethod, so _isfile and _exists changed too,
for consistency.

CI is green: https://travis-ci.org/pantsbuild/pants/builds/74278317

Reviewed at https://rbcommons.com/s/twitter/r/2572/

Coverage Stats

14379 of 20833 relevant lines covered (69.02%)

0.69 hits per line

pantsbuild / pants / 6005 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6005.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 6005 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6005.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 6005 / 3
0%
main: 93%

README BADGES
x