pantsbuild / pants / 6005

0%

push

travis-ci

Handle recursive globs with build-file-rev

Previously, build-file-rev with recursive globs would fail in two ways:
1. cmd_line_spec_parser would mistakenly look for the glob directory
in the filesystem even.

2. Some relative paths would contain dot components (e.g. ./foo), and
_realpath_uncached would fail to handle these.

This patch fixes both of these problems.

The recursive glob check had to move inside scan_buildfiles.  To do
so, _isdir became a classmethod, so _isfile and _exists changed too,
for consistency.

CI is green: https://travis-ci.org/pantsbuild/pants/builds/74278317

Reviewed at https://rbcommons.com/s/twitter/r/2572/

24 of 24 new or added lines in 3 files covered. (100.0%)

15282 of 20833 relevant lines covered (73.35%)

1.38 hits per line