14
66%
master: 66%

Ran 13 Nov 2020 12:39AM UTC

Files 114

Run time 10s

Badge

Embed ▾

Committed 13 Nov 2020 12:24AM UTC coverage: 65.355% (+0.003%) from 65.352%

Job # TESTFLAGS="--coverage" CONTAINER="netaccess"

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

Refactoring tls.Config mutation out of grpc (#5175)

In all boulder services, we construct a single tls.Config object
and then pass it into multiple gRPC setup methods. In all boulder
services but one, we pass the object into multiple clients, and
just one server. In general, this is safe, because all of the client
setup happens on the main thread, and the server setup similarly
happens on the main thread before spinning off the gRPC server
goroutine.

In the CA, we do the above and pass the tlsConfig object into two
gRPC server setup functions. Thus the first server goroutine races
with the setup of the second server.

This change removes the post-hoc assignment of MinVersion,
MaxVersion, and CipherSuites of the tls.Config object passed
to grpc.ClientSetup and grpc.NewServer. And adds those same
values to the cmd.TLSConfig.Load, the method responsible for
constructing the tls.Config object before it's passed to
grpc.ClientSetup and grpc.NewServer.

Part of #5159

Run Details

13292 of 20338 relevant lines covered (65.36%)

0.73 hits per line

letsencrypt / boulder / 13199 / 14
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 13199.14 (TESTFLAGS="--coverage" CONTAINER="netaccess")

letsencrypt / boulder / 13199 / 14 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 13199.14 (TESTFLAGS="--coverage" CONTAINER="netaccess")

letsencrypt / boulder / 13199 / 14
66%
master: 66%

README BADGES
x