13
66%
master: 66%

Ran 13 Nov 2020 12:02AM UTC

Files 114

Run time 13s

Badge

Embed ▾

Committed 12 Nov 2020 11:46PM UTC coverage: 65.352% (+0.02%) from 65.336%

Job # TESTFLAGS="--coverage" CONTAINER="netaccess"

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

Truncate order expiry values before storage (#5178)

The database stores order expiry values as type DATETIME, which only
supports values with second-level accuracy. (Contrast with type
DATETIME(6), which allows microsecond accuracy.) But the order object
being written to the database does not have its expiry value rewritten
by the insert process. This leads to Boulder returning different
values for `expires` depending on whether the order was created fresh
(nanosecond accuracy) or retrieved from the db (second accuracy).

There appears to be only one codepath which suffers from this
discrepancy. Although Authorization objects also have an `expires`
field, they are never returned to the client immediately upon creation;
they are first exposed to the user as URLs within an Order object, and
so are always retrieved from the database.

Fixes #5166

Run Details

13292 of 20339 relevant lines covered (65.35%)

0.73 hits per line

letsencrypt / boulder / 13198 / 13
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 13198.13 (TESTFLAGS="--coverage" CONTAINER="netaccess")

letsencrypt / boulder / 13198 / 13 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 13198.13 (TESTFLAGS="--coverage" CONTAINER="netaccess")

letsencrypt / boulder / 13198 / 13
66%
master: 66%

README BADGES
x