• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

letsencrypt / boulder / 13199
66%
master: 66%

Build:
Build:
LAST BUILD BRANCH: ocsp-fail-stops-issuances
DEFAULT BRANCH: master
Ran 13 Nov 2020 12:38AM UTC
Jobs 2
Files 114
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

13 Nov 2020 12:24AM UTC coverage: 65.355% (+0.003%) from 65.352%
13199

push

travis-pro

web-flow
Refactoring tls.Config mutation out of grpc (#5175)

In all boulder services, we construct a single tls.Config object
and then pass it into multiple gRPC setup methods. In all boulder
services but one, we pass the object into multiple clients, and
just one server. In general, this is safe, because all of the client
setup happens on the main thread, and the server setup similarly
happens on the main thread before spinning off the gRPC server
goroutine.

In the CA, we do the above and pass the tlsConfig object into two
gRPC server setup functions. Thus the first server goroutine races
with the setup of the second server.

This change removes the post-hoc assignment of MinVersion,
MaxVersion, and CipherSuites of the tls.Config object passed
to grpc.ClientSetup and grpc.NewServer. And adds those same
values to the cmd.TLSConfig.Load, the method responsible for
constructing the tls.Config object before it's passed to
grpc.ClientSetup and grpc.NewServer.

Part of #5159

5 of 5 new or added lines in 1 file covered. (100.0%)

13292 of 20338 relevant lines covered (65.36%)

1.46 hits per line

Jobs
ID Job ID Ran Files Coverage
13 13199.13 (TESTFLAGS="--coverage" CONTAINER="netaccess") 13 Nov 2020 12:38AM UTC 0
65.36
Travis Job 13199.13
14 13199.14 (TESTFLAGS="--coverage" CONTAINER="netaccess") 13 Nov 2020 12:39AM UTC 0
65.36
Travis Job 13199.14
Source Files on build 13199
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #13199
  • 07aef67f on github
  • Prev Build on main (#13198)
  • Next Build on main (#13210)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc