3
0%
main: 93%

Ran 08 Jul 2015 09:49PM UTC

Files 332

Run time 14s

Badge

Embed ▾

Committed 08 Jul 2015 09:45PM UTC coverage: 66.516% (-0.4%) from 66.89%

Job # CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'"

Build Type

push

travis-ci

Committed by John Sirois

Commit Message

Fixup BuildFile must_exist logic.

Relax the BuildFile.must_exist logic to ensure a logical BUILD file
exists.  Previously the logic required the primary canonical BUILD file
(no extension) to be a valid BUILD file and not a directory if a valid
sibling BUILD file existed.

This change adds a failing test that is then fixed.
Along the way, centralize BUILD file `._isfile` testing in
`_get_all_build_files`.

Testing Done:
Before fix, the new test failed like so:
```console
$ ./pants test tests/python/pants_test/base:filesystem_build_file -- -ktest_dir_is_primary
...
                     E         MissingBuildFileError: Path to buildfile (/tmp/tmp7ZEf8n/root/issue_1742/BUILD) is a directory, but it must be a file.

                     src/python/pants/base/build_file.py:167: MissingBuildFileError
...
```

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/70123652

Bugs closed: 1742, 1774

Reviewed at https://rbcommons.com/s/twitter/r/2441/

Coverage Stats

13276 of 19959 relevant lines covered (66.52%)

0.67 hits per line

pantsbuild / pants / 5540 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5540.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 5540 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5540.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 5540 / 3
0%
main: 93%

README BADGES
x