5540
0%
main: 93%

Ran 08 Jul 2015 09:45PM UTC

Jobs 10

Files 332

Run time 12min

Badge

Embed ▾

pending completion

Build # 5540

Build Type

push

travis-ci

Committed by John Sirois

Commit Message

Fixup BuildFile must_exist logic.

Relax the BuildFile.must_exist logic to ensure a logical BUILD file
exists.  Previously the logic required the primary canonical BUILD file
(no extension) to be a valid BUILD file and not a directory if a valid
sibling BUILD file existed.

This change adds a failing test that is then fixed.
Along the way, centralize BUILD file `._isfile` testing in
`_get_all_build_files`.

Testing Done:
Before fix, the new test failed like so:
```console
$ ./pants test tests/python/pants_test/base:filesystem_build_file -- -ktest_dir_is_primary
...
                     E         MissingBuildFileError: Path to buildfile (/tmp/tmp7ZEf8n/root/issue_1742/BUILD) is a directory, but it must be a file.

                     src/python/pants/base/build_file.py:167: MissingBuildFileError
...
```

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/70123652

Bugs closed: 1742, 1774

Reviewed at https://rbcommons.com/s/twitter/r/2441/

Coverage Stats

14181 of 19959 relevant lines covered (71.05%)

1.34 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	5540.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	08 Jul 2015 09:45PM UTC		Travis Job 5540.1
2	5540.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	08 Jul 2015 09:50PM UTC	67.19	Travis Job 5540.2
3	5540.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	08 Jul 2015 09:49PM UTC	66.52	Travis Job 5540.3
4	5540.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	08 Jul 2015 09:49PM UTC		Travis Job 5540.4
5	5540.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	08 Jul 2015 09:51PM UTC		Travis Job 5540.5
6	5540.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	08 Jul 2015 09:51PM UTC		Travis Job 5540.6
7	5540.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	08 Jul 2015 09:58PM UTC		Travis Job 5540.7
8	5540.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	08 Jul 2015 09:55PM UTC		Travis Job 5540.8
9	5540.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	08 Jul 2015 09:57PM UTC		Travis Job 5540.9
10	5540.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	08 Jul 2015 09:57PM UTC		Travis Job 5540.10

Source Files on build 5540

Detailed source file information is not available for this build.

pantsbuild / pants / 5540
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5540

pantsbuild / pants / 5540 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5540

pantsbuild / pants / 5540
0%
main: 93%

README BADGES
x