3
0%
main: 93%

Ran 06 Jun 2015 08:08AM UTC

Files 328

Run time 14s

Badge

Embed ▾

Committed 06 Jun 2015 08:00AM UTC coverage: 65.326% (-0.4%) from 65.732%

Job # CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'"

Build Type

push

travis-ci

Committed by Benjy

Commit Message

Various refactoring of PythonChroot and related code.

- Fold all pex interaction into PythonChroot/temporary_chroot().
  Clients of PythonChroot no longer use PEX, PEXBuilder etc. directly.
- Get rid of resolver.py and move its functionality into its only
  client - PythonChroot. So instead of passing in many arguments,
  it can read from self.
- Make most optional arguments required, in methods we were always
  passing those arguments into anyway.
- Rename the egg_cache_dir option to the more precise 'resolver_cache_dir',
  and move the global cache ttl option to be a PythonSetup option.
- Make the order of various arguments uniform.

All this simplification is good in its own right, but my motivation
for doing it now is as a means to the future end of implementing caching
of entire chroots, which in turn will make many things, including test
running, much faster.

Testing Done:
CI passed here: https://travis-ci.org/pantsbuild/pants/builds/65667369.

Bugs closed: 1641

Reviewed at https://rbcommons.com/s/twitter/r/2327/

Coverage Stats

12828 of 19637 relevant lines covered (65.33%)

0.65 hits per line

pantsbuild / pants / 5217 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5217.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 5217 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5217.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 5217 / 3
0%
main: 93%

README BADGES
x