5217
0%
main: 93%

Ran 06 Jun 2015 08:08AM UTC

Jobs 10

Files 328

Run time 11min

Badge

Embed ▾

pending completion

Build # 5217

Build Type

push

travis-ci

Committed by Benjy

Commit Message

Various refactoring of PythonChroot and related code.

- Fold all pex interaction into PythonChroot/temporary_chroot().
  Clients of PythonChroot no longer use PEX, PEXBuilder etc. directly.
- Get rid of resolver.py and move its functionality into its only
  client - PythonChroot. So instead of passing in many arguments,
  it can read from self.
- Make most optional arguments required, in methods we were always
  passing those arguments into anyway.
- Rename the egg_cache_dir option to the more precise 'resolver_cache_dir',
  and move the global cache ttl option to be a PythonSetup option.
- Make the order of various arguments uniform.

All this simplification is good in its own right, but my motivation
for doing it now is as a means to the future end of implementing caching
of entire chroots, which in turn will make many things, including test
running, much faster.

Testing Done:
CI passed here: https://travis-ci.org/pantsbuild/pants/builds/65667369.

Bugs closed: 1641

Reviewed at https://rbcommons.com/s/twitter/r/2327/

Coverage Stats

13654 of 19637 relevant lines covered (69.53%)

1.31 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	5217.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	06 Jun 2015 08:10AM UTC		Travis Job 5217.1
2	5217.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	06 Jun 2015 08:09AM UTC	65.5	Travis Job 5217.2
3	5217.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	06 Jun 2015 08:08AM UTC	65.33	Travis Job 5217.3
4	5217.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	06 Jun 2015 08:08AM UTC		Travis Job 5217.4
5	5217.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	06 Jun 2015 08:10AM UTC		Travis Job 5217.5
6	5217.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	06 Jun 2015 08:17AM UTC		Travis Job 5217.6
7	5217.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	06 Jun 2015 08:17AM UTC		Travis Job 5217.7
8	5217.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	06 Jun 2015 08:19AM UTC		Travis Job 5217.8
9	5217.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	06 Jun 2015 08:19AM UTC		Travis Job 5217.9
10	5217.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	06 Jun 2015 08:19AM UTC		Travis Job 5217.10

Source Files on build 5217

Detailed source file information is not available for this build.

pantsbuild / pants / 5217
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5217

pantsbuild / pants / 5217 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5217

pantsbuild / pants / 5217
0%
main: 93%

README BADGES
x