buildtesters / buildtest / 455 / 5

76%

devel: 76%

push

travis-ci-com

Status check (#286)

* add implementation to report test state based on 'status' object defined
in Buildspec.
Add method check_returncode and check_regex to BuilderBase class that
return boolean True/False.
If status is not defined, we perform check based on returncode from
test. If its a 0, test_state=PASS otherwise set to FAIL.
We add the following keys to self.metadata: 'outfile', 'errfile',
'TEST_STATE'.
In buildtest/menu/build.py we count PASS/FAIL test based on
self.metadata['TEST_STATE']

* make use of self.metadata['outfile'] and self.metadata['errfile'] when
writing output and error stream to files.

* add docstring for check_returncode and check_regex method in BuilderBase

* fix black issue

Signed-off-by: Shahzeb Siddiqui <shahzebmsiddiqui@gmail.com>

* adding utility method read_file and write_file for reading and writing
files. Refactor Builderbase to use read_file and write_file when
writing output and error file.
Adding regression test for checking the two utility methods.

* forgot to address an issue raised by @vsoch regarding key search
in status dictionary.

* add method read, write which are doing the read and write operation.
Refactor read_file and write_file.
We expect input content for writing to be a string.

* remove method 'read' and  'write' and merge them to 'read_file' and
'write_file'

* applying black

Signed-off-by: Shahzeb Siddiqui <shahzebmsiddiqui@gmail.com>

* update comments near method invocation 'self.check_regex',
'self.check_returncode'
Remove if conditions in self.check_returncode

* set test_state=FAIL as default value.
self.check_regex was spliting each string by character which was not
right.

* applying black

* refactor read_file and write_file so that we raise error when
input type is invalid. Rewrite regtest for read_file, write_file based
on recent change.
Update docstrings

* Add print statement, and increase coverage for file
buildtest/utils/fil... (continued)

154 of 270 branches covered (57.04%)

Branch coverage included in aggregate %.

556 of 829 relevant lines covered (67.07%)

0.67 hits per line