3
0%
main: 93%

Ran 20 May 2015 05:23PM UTC

Files 325

Run time 16s

Badge

Embed ▾

Committed 20 May 2015 05:11PM UTC coverage: 65.066%. Remained the same

Job # CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'"

Build Type

push

travis-ci

Committed by John Sirois

Commit Message

Convert validation.assert_list isinstance checking to be lazy

Single line alteration - pants.base.validation.assert_list is called frequently and I added laziness to avoid unneccesary function calls. Saw this when profiling and wanted to fix it despite it not being a huge win...

I also added unit tests for this function which doesn't appear to be directly unit before this.

Testing Done:
Pull request https://github.com/pantsbuild/pants/pull/1550 runs the Travis CI suite and it all passes.

I can't seem to run the ci script myself but I did run all the unit tests which pass and verified that the new test_validation target was included in the tests that run. One of the tests demonstrates the lazyness of the new version.

Bugs closed: 1550

Reviewed at https://rbcommons.com/s/twitter/r/2228/

Coverage Stats

12667 of 19468 relevant lines covered (65.07%)

0.65 hits per line

pantsbuild / pants / 4960 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4960.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 4960 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4960.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 4960 / 3
0%
main: 93%

README BADGES
x