4960
0%
main: 93%

Ran 20 May 2015 05:22PM UTC

Jobs 10

Files 325

Run time 14min

Badge

Embed ▾

pending completion

Build # 4960

Build Type

push

travis-ci

Committed by John Sirois

Commit Message

Convert validation.assert_list isinstance checking to be lazy

Single line alteration - pants.base.validation.assert_list is called frequently and I added laziness to avoid unneccesary function calls. Saw this when profiling and wanted to fix it despite it not being a huge win...

I also added unit tests for this function which doesn't appear to be directly unit before this.

Testing Done:
Pull request https://github.com/pantsbuild/pants/pull/1550 runs the Travis CI suite and it all passes.

I can't seem to run the ci script myself but I did run all the unit tests which pass and verified that the new test_validation target was included in the tests that run. One of the tests demonstrates the lazyness of the new version.

Bugs closed: 1550

Reviewed at https://rbcommons.com/s/twitter/r/2228/

Coverage Stats

13472 of 19468 relevant lines covered (69.2%)

1.3 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4960.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	20 May 2015 05:24PM UTC		Travis Job 4960.1
2	4960.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	20 May 2015 05:24PM UTC	65.03	Travis Job 4960.2
3	4960.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	20 May 2015 05:23PM UTC	65.07	Travis Job 4960.3
4	4960.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	20 May 2015 05:22PM UTC		Travis Job 4960.4
5	4960.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	20 May 2015 05:24PM UTC		Travis Job 4960.5
6	4960.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	20 May 2015 05:33PM UTC		Travis Job 4960.6
7	4960.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	20 May 2015 05:34PM UTC		Travis Job 4960.7
8	4960.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	20 May 2015 05:35PM UTC		Travis Job 4960.8
9	4960.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	20 May 2015 05:32PM UTC		Travis Job 4960.9
10	4960.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	20 May 2015 05:37PM UTC		Travis Job 4960.10

Source Files on build 4960

Detailed source file information is not available for this build.

pantsbuild / pants / 4960
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4960

pantsbuild / pants / 4960 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4960

pantsbuild / pants / 4960
0%
main: 93%

README BADGES
x