1
89%
master: 89%

Ran 21 Nov 2019 08:51PM UTC

Files 266

Run time 15s

Badge

Embed ▾

Committed 21 Nov 2019 08:37PM UTC coverage: 87.265% (+0.006%) from 87.259%

Job # 16223.1

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

remove getLoadStatsStore method from LocalityStore

Currently `LoadStatsStore` is create by `LocalityStore` and `LoadReportClient` retrieves `LoadStatsStore` from `LocalityStore.getLoadStatsStore()`.

But `LocalityStore` is create by EDS policy, whereas `LoadReportClient` and `LoadStatsStore` should be created by CDS (if not EDS-only), before `LocalityStore` is created. If `LoadReportClient` is embedded in `XdsClientImpl`, it need a `LoadStatsStore` which shouldn't be created by `LocalityStore`.

Instead, `LoadStatsStore` should be create before `LocalityStore` is created, and be passed to `LocalityStore`'s constructor. A getter is not needed.

Run Details

15301 of 17534 relevant lines covered (87.26%)

0.87 hits per line

grpc / grpc-java / 16223 / 1
89%
master: 89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 16223.1

grpc / grpc-java / 16223 / 1 89% master: 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 16223.1

grpc / grpc-java / 16223 / 1
89%
master: 89%

README BADGES
x