16223
89%

Ran 21 Nov 2019 08:51PM UTC

Jobs 1

Files 266

Run time 16s

Badge

Embed ▾

pending completion

Build # 16223

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

remove getLoadStatsStore method from LocalityStore

Currently `LoadStatsStore` is create by `LocalityStore` and `LoadReportClient` retrieves `LoadStatsStore` from `LocalityStore.getLoadStatsStore()`.

But `LocalityStore` is create by EDS policy, whereas `LoadReportClient` and `LoadStatsStore` should be created by CDS (if not EDS-only), before `LocalityStore` is created. If `LoadReportClient` is embedded in `XdsClientImpl`, it need a `LoadStatsStore` which shouldn't be created by `LocalityStore`.

Instead, `LoadStatsStore` should be create before `LocalityStore` is created, and be passed to `LocalityStore`'s constructor. A getter is not needed.

Run Details

15301 of 17534 relevant lines covered (87.26%)

0.87 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	16223.1	21 Nov 2019 08:51PM UTC	0	87.26	Travis Job 16223.1

Source Files on build 16223

Detailed source file information is not available for this build.

grpc / grpc-java / 16223
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 16223

grpc / grpc-java / 16223 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 16223

grpc / grpc-java / 16223
89%

README BADGES
x