3
0%
main: 93%

Ran 14 Apr 2015 03:05AM UTC

Files 319

Run time 17s

Badge

Embed ▾

Committed 14 Apr 2015 02:55AM UTC coverage: 69.086% (+0.03%) from 69.059%

Job # CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'"

Build Type

push

travis-ci

Committed by

dturner-tw

Commit Message

Classpath isolation: make ivy resolution locally accurate.

In the global compilation strategy, the 'compile_classpath' product
contains a list of artifacts for each target.  This list need not be
accurate per-target so long as the total set of artifacts required for
the build is included somewhere in the product.  In ivy resolution, a
target T might request library L, version 1.0.  If some other target U
in the build brings in L 2.0, Ivy might not resolve L 1.0's
dependencies.  So, prior to this patch, the compile_classpath for T
would show L, but not L's dependencies.

In the isolated compilation strategy, compile_classpath must be
accurate per-target, since targets will be built independently.  So
if T were missing L's dependencies, T might not be buildable.

This patch solves this problem by ignoring version numbers when
retrieving dependencies, so that the resolved version can replace
the requested version in all cases.

Note that ivy resolution is still not 100% isolated; if T is built in
the same compile as U, it will be built against L 2.0, while if it is
built alone, it will be built against L 1.0.

Testing Done:
CI green: https://travis-ci.org/pantsbuild/pants/builds/58371122

Reviewed at https://rbcommons.com/s/twitter/r/2064/

Coverage Stats

12897 of 18668 relevant lines covered (69.09%)

0.69 hits per line

pantsbuild / pants / 4483 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4483.3 (CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'")

pantsbuild / pants / 4483 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4483.3 (CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'")

pantsbuild / pants / 4483 / 3
0%
main: 93%

README BADGES
x